Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename XDR ticker (conflict with ISO 4217) #2529

Merged
merged 1 commit into from
Mar 25, 2019
Merged

rename XDR ticker (conflict with ISO 4217) #2529

merged 1 commit into from
Mar 25, 2019

Conversation

vlad-khramov
Copy link
Contributor

See #2503

@ManfredKarrer ManfredKarrer requested a review from blabno March 11, 2019 15:34
blabno
blabno reviewed Mar 11, 2019
View reviewed changes
Copy link

@blabno blabno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't tickers be uppercase?

@vlad-khramov
Copy link
Contributor Author

vlad-khramov commented Mar 11, 2019 •
edited
Loading

I have not found this restriction in https://docs.bisq.network/exchange/howto/list-asset.html
and there is at least one coin with not uppercase ticker
https://github.com/bisq-network/bisq/blob/master/assets/src/main/java/bisq/asset/coins/QMCoin.java

Should I make it uppercased?

@ManfredKarrer
Copy link
Contributor

I think we don't have a strict requirement for that but I would say lets keep it uppercase. Uppercase is the standard.

@vlad-khramov
Copy link
Contributor Author

Can I use digit in the beginning of ticker ("1XDR")?
Creators of blockchain want bXDR or 1XDR (reason - XDR is highlighted) since simple XDR is prohibited

@blabno
Copy link

blabno commented Mar 12, 2019

Man, ticker is a ticker. There is a name where you can play a bit.

blabno
blabno approved these changes Mar 19, 2019
View reviewed changes
Copy link

@blabno blabno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ripcurlx ripcurlx merged commit c9c775d into bisq-network:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blabno blabno blabno approved these changes

Assignees
No one assigned
Labels
in:altcoins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vlad-khramov @ManfredKarrer @blabno @ripcurlx