Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid rate for btc/xdr #2503

Closed
vlad-khramov opened this issue Mar 6, 2019 · 10 comments
Closed

Invalid rate for btc/xdr #2503

vlad-khramov opened this issue Mar 6, 2019 · 10 comments

Comments

@vlad-khramov
Copy link
Contributor

vlad-khramov commented Mar 6, 2019

image

xdr/btc is 2768. It is wrong. Must be btc/xdr = 2768 (1 xdr ~= 1.39)

For example see https://www.coingecko.com/en/coins/bitcoin/xdr

--
Orders with XDR couldn't be created since difference with this rate > 30%

@ghost
Copy link

ghost commented Mar 6, 2019

@quantum13
yes there seems to be a problem with this price.
(I can't even find XDR on poloniex.com)

@vlad-khramov
Copy link
Contributor Author

0.9.5

@ripcurlx
Copy link
Contributor

ripcurlx commented Mar 7, 2019

If I start in locally on Regtest I actually see N/A which is correct as Poloniex doesn't deliver a price ticker for this altcoin. On Production I get from the pricenodes the wrong value as mentioned above.

@ManfredKarrer Do you have an idea how the price node gets this ticker if Poloniex doesn't return anything?

@ghost
Copy link

ghost commented Mar 7, 2019

Something is provided, since
eg http://5bmpx76qllutpcyp.onion/getAllMarketPrices
returns a XDR field.

180  
currencyCode "XCP"
price 0.00042221
timestampSec 1551969634894
provider "POLO"
181  
-- --
currencyCode "XDR"
price 2772.27
timestampSec 1551969455149
provider "BTCA_G"

but it's not from Poloniex.

(I guess BTCA_G means BitcoinAverage ?)

I notice that the field #180 is XCP, provided from Poloniex, and which seems delisted. (neither in the display altcoins list, neither in the add altcoin list).
Maybe there is some slippage between the 2 ?

@ripcurlx
Copy link
Contributor

ripcurlx commented Mar 7, 2019

The problem is that the PR for XDR didn't comply with https://docs.bisq.network/exchange/howto/list-asset.html#the-asset-ticker-symbol-must-not-conflict-with-national-currency-tickers.

There is a fiat currency with the same currency code XDR (https://en.wikipedia.org/wiki/Special_drawing_rights).

So the PR shouldn't have been merged in the first place.

@ManfredKarrer
Copy link
Contributor

xdr has to be removed as it conflicts with our requirements.

@vlad-khramov
Copy link
Contributor Author

@ManfredKarrer I will create PR for renaming XDR to something else, sorry

@ManfredKarrer
Copy link
Contributor

@stale
Copy link

stale bot commented Jun 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Jun 5, 2019
@stale
Copy link

stale bot commented Jun 12, 2019

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants