Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #1533

Merged
merged 2 commits into from
May 8, 2018
Merged

Fix typos #1533

merged 2 commits into from
May 8, 2018

Conversation

rex4539
Copy link
Contributor

@rex4539 rex4539 commented May 7, 2018

No description provided.

@cbeams cbeams self-requested a review May 8, 2018 06:30
Copy link
Contributor

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. This is excellent, @rex4539, thank you!

If you'd like to do more of this kind of work, it would be most welcome. Take a look at https://github.com/bisq-network/bisq-core/blob/master/src/main/resources/i18n/displayStrings.properties, which defines most of the text you see throughout the Bisq Desktop application.

Also, if you haven't yet, please read through the https://bisq.network/contributor-checklist, and be sure to submit a compensation request for any further work you contribute.

This script is generated by running `gradle wrapper`, so it's best not
to modify it at all. To actually fix this typo, a pull request should be
submitted to https://github.com/gradle/gradle itself.
@cbeams
Copy link
Contributor

cbeams commented May 8, 2018

@rex4539, note that I just pushed review commit e5c99e2.

@cbeams cbeams merged commit e5c99e2 into bisq-network:master May 8, 2018
cbeams added a commit that referenced this pull request May 8, 2018
@rex4539 rex4539 deleted the fix-typos branch May 8, 2018 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants