-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application freezes on take offer screen #2509
Comments
@wallacedf Could you please post the log output when you experience this issue, so we can see why this is behaving like that for you. |
This might be related to #2506. @ManfredKarrer As we see in the log file |
But actually not - as this happens during offer creation, not when taking the offer. |
@wallacedf Are you taking a buy offer to sell BTC or creating a new one? |
Looking at the log file @wallacedf is taking an existing offer, so it might be related to the latest change to prevent lost trading fees. |
I'm taking an existing offer. And I also had the same issue with 0.9.4. I updated to 0.9.5 hoping that it would be gone but it happens both in 0.9.4 and 0.9.5 |
Do you run on a desktop or VM? How much ram do you have? Which OS? |
Hi @ManfredKarrer , I run Bisq on a real Lubuntu 16.10 machine. I have 8 GB of RAM. When I run into the issue, RAM starts as low as 1GB and eventually all 8 GB are consumed -- making the whole OS unresponsive until I kill Bisq's process and then everything gets back to normal. |
I've been experiencing a memory leak also, running on a VPS with 2G RAM. The app runs without problems for several days and eventually it runs out of heap space and produces similar symptoms (unresponsive UI). This happens both with or without buy or sell orders being active. Ubuntu 18.04 |
@peterzen Do you use latest master version or latest release? |
@wallacedf Do you use latest master version or latest release? |
If you run master, please update to latest commit, there have been issues in one of the past commits. |
Running 0.9.5, been experiencing this since 0.9.3
…On Fri, Mar 8, 2019 at 9:45 PM Manfred Karrer ***@***.***> wrote:
If you run master, please update to latest commit, there have been issues
in one of the past commits.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2509 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFmy5DVNsicGgmgiwfGX85WSC3069ZRsks5vUsvRgaJpZM4bjMIh>
.
|
@peterzen from master or release? Can you try from master to verify if its still there? |
From 0.9.5 release - restarted the app on openJDK 10, will keep it running for a few days and report back to confirm whether the problem persists. |
It is looking good on my end - the leak seems to be gone on the above setup. |
Maybe its related to JDK 11? |
Quite possibly, 0.9.3-0.9.5 was reproducibly running out of heap space after a few days with or without active orders being on. |
I'm still experiencing the issue using JDK 8. I'll try to run it using JDK 10 and see if it also solves for me. Thanks! |
@wallacedf You use prob. an old version of Bisq. If you run from source you need to use JDK 10. If you run the binary the JDK is packed into the binary so your local JDK is irrelevant. If you run from binary which version do you use? Please update to latest as ther has been a fix realted to that. |
I installed and use the version from https://bisq.network/downloads/v0.9.5/Bisq-64bit-0.9.5.deb Is there an updated one? |
@wallacedf The installed java version only matters if you build from the sources. |
@wallacedf Are you still experiencing this problem with the current version? |
Update the gradle dependency to JavaFX 14. This brings to Bisq the latest JavaFX fixes and improvements, especially in the areas of UI performance, memory management and security. JavaFX can be upgraded independently of the JDK used to build the application, so this change is modular and does not affect other parts of the build process. Related / likely related to: bisq-network#350 bisq-network#2135 bisq-network#2509 bisq-network#3128 bisq-network#3307 bisq-network#3308 bisq-network#3343 bisq-network#3430 bisq-network#3657 bisq-network#3677 bisq-network#3683 bisq-network#3686 bisq-network#3786 bisq-network#3787 bisq-network#3892 bisq-network#3917 bisq-network#3918 bisq-network#3936
Update the gradle dependency to JavaFX 14. This brings to Bisq the latest JavaFX fixes and improvements, especially in the areas of UI performance, memory management and security. JavaFX can be upgraded independently of the JDK used to build the application, so this change is modular and does not affect other parts of the build process. Related / likely related to: bisq-network#350 bisq-network#2135 bisq-network#2509 bisq-network#3128 bisq-network#3307 bisq-network#3308 bisq-network#3343 bisq-network#3430 bisq-network#3657 bisq-network#3677 bisq-network#3683 bisq-network#3686 bisq-network#3786 bisq-network#3787 bisq-network#3892 bisq-network#3917 bisq-network#3918 bisq-network#3936
Should be fixed in the most recent release (v1.6.4) which brings massive UI performance improvements. Please try it out and let us know if it's still an issue for you. |
Hello!
I'm using Bisq 0.9.5 on Linux and I noticed that whenever I try to sell BTC, the application freezes on the screen that asks you to fund the offer either with your Bisq wallet and using an external wallet.
The app becomes impossible to use and I can see that it seems to consume all available RAM until it finally crashes:
It looks like some loop is leaking memory... I suspect it might be related with the 'Waiting payment confirmation....' process but I can't tell. I really love the whole concept behind Bisq but this is such a really annoying issue and might scare people away from using Bisq, specially because the app may crash right after you confirm that you want to take an offer. It would be a really great thing to fix.
Thank you!
The text was updated successfully, but these errors were encountered: