Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application freezes on take offer screen #2509

Closed
wallacedf opened this issue Mar 7, 2019 · 25 comments
Closed

Application freezes on take offer screen #2509

wallacedf opened this issue Mar 7, 2019 · 25 comments
Assignees
Labels

Comments

@wallacedf
Copy link

Hello!

I'm using Bisq 0.9.5 on Linux and I noticed that whenever I try to sell BTC, the application freezes on the screen that asks you to fund the offer either with your Bisq wallet and using an external wallet.

The app becomes impossible to use and I can see that it seems to consume all available RAM until it finally crashes:
memory-issue

It looks like some loop is leaking memory... I suspect it might be related with the 'Waiting payment confirmation....' process but I can't tell. I really love the whole concept behind Bisq but this is such a really annoying issue and might scare people away from using Bisq, specially because the app may crash right after you confirm that you want to take an offer. It would be a really great thing to fix.

Thank you!

@ripcurlx ripcurlx added the a:bug label Mar 7, 2019
@ripcurlx
Copy link
Contributor

ripcurlx commented Mar 7, 2019

@wallacedf Could you please post the log output when you experience this issue, so we can see why this is behaving like that for you.

@wallacedf
Copy link
Author

@ripcurlx , thanks for the quick reply. That's what I get in the logs when the issue happens:
bisq.log

@ripcurlx
Copy link
Contributor

ripcurlx commented Mar 7, 2019

This might be related to #2506.

@ManfredKarrer As we see in the log file We got 2 sendMessage requests in less than 20 ms. We set the thread to sleep for 50 ms to avoid flooding our peer. In kind of a endless loop. Can it be that this is related to the deposit and trading fee transaction that are now in version 0.9.5 sent in closer time range than before?

@ripcurlx
Copy link
Contributor

ripcurlx commented Mar 7, 2019

But actually not - as this happens during offer creation, not when taking the offer.

@ripcurlx
Copy link
Contributor

ripcurlx commented Mar 7, 2019

@wallacedf Are you taking a buy offer to sell BTC or creating a new one?

@ripcurlx
Copy link
Contributor

ripcurlx commented Mar 7, 2019

Looking at the log file @wallacedf is taking an existing offer, so it might be related to the latest change to prevent lost trading fees.

@wallacedf
Copy link
Author

I'm taking an existing offer. And I also had the same issue with 0.9.4. I updated to 0.9.5 hoping that it would be gone but it happens both in 0.9.4 and 0.9.5

@ManfredKarrer
Copy link
Contributor

Do you run on a desktop or VM? How much ram do you have? Which OS?

@wallacedf
Copy link
Author

Hi @ManfredKarrer ,

I run Bisq on a real Lubuntu 16.10 machine. I have 8 GB of RAM. When I run into the issue, RAM starts as low as 1GB and eventually all 8 GB are consumed -- making the whole OS unresponsive until I kill Bisq's process and then everything gets back to normal.

@peterzen
Copy link
Contributor

peterzen commented Mar 8, 2019

I've been experiencing a memory leak also, running on a VPS with 2G RAM. The app runs without problems for several days and eventually it runs out of heap space and produces similar symptoms (unresponsive UI). This happens both with or without buy or sell orders being active.

Ubuntu 18.04
openjdk-11-jdk-headless

@ManfredKarrer
Copy link
Contributor

@peterzen Do you use latest master version or latest release?
jdk 11 is not supported yet. Better use openjdk-10 to be sure that there are not issues.

@ManfredKarrer
Copy link
Contributor

@wallacedf Do you use latest master version or latest release?

@ManfredKarrer
Copy link
Contributor

If you run master, please update to latest commit, there have been issues in one of the past commits.

@peterzen
Copy link
Contributor

peterzen commented Mar 8, 2019 via email

@ManfredKarrer
Copy link
Contributor

@peterzen from master or release? Can you try from master to verify if its still there?

@peterzen
Copy link
Contributor

peterzen commented Mar 8, 2019

From 0.9.5 release - restarted the app on openJDK 10, will keep it running for a few days and report back to confirm whether the problem persists.

@peterzen
Copy link
Contributor

From 0.9.5 release - restarted the app on openJDK 10, will keep it running for a few days and report back to confirm whether the problem persists.

It is looking good on my end - the leak seems to be gone on the above setup.

@ManfredKarrer
Copy link
Contributor

Maybe its related to JDK 11?

@peterzen
Copy link
Contributor

Quite possibly, 0.9.3-0.9.5 was reproducibly running out of heap space after a few days with or without active orders being on.

@wallacedf
Copy link
Author

I'm still experiencing the issue using JDK 8. I'll try to run it using JDK 10 and see if it also solves for me. Thanks!

@ManfredKarrer
Copy link
Contributor

@wallacedf You use prob. an old version of Bisq. If you run from source you need to use JDK 10. If you run the binary the JDK is packed into the binary so your local JDK is irrelevant. If you run from binary which version do you use? Please update to latest as ther has been a fix realted to that.

@wallacedf
Copy link
Author

I installed and use the version from https://bisq.network/downloads/v0.9.5/Bisq-64bit-0.9.5.deb

Is there an updated one?

@ghost
Copy link

ghost commented Mar 12, 2019

@wallacedf
v0.9.5 is the last version.
If you use the binary, the installed java version doesn't matter.

The installed java version only matters if you build from the sources.

@ripcurlx
Copy link
Contributor

@wallacedf Are you still experiencing this problem with the current version?

cd2357 added a commit to cd2357/bisq that referenced this issue May 7, 2020
Update the gradle dependency to JavaFX 14.

This brings to Bisq the latest JavaFX fixes and improvements, especially
 in the areas of UI performance, memory management and security.

JavaFX can be upgraded independently of the JDK used to build the
application, so this change is modular and does not affect other parts
of the build process.

Related / likely related to: bisq-network#350 bisq-network#2135 bisq-network#2509 bisq-network#3128 bisq-network#3307 bisq-network#3308 bisq-network#3343
bisq-network#3430 bisq-network#3657 bisq-network#3677 bisq-network#3683 bisq-network#3686 bisq-network#3786 bisq-network#3787 bisq-network#3892 bisq-network#3917 bisq-network#3918 bisq-network#3936
cd2357 added a commit to cd2357/bisq that referenced this issue Sep 16, 2020
Update the gradle dependency to JavaFX 14.

This brings to Bisq the latest JavaFX fixes and improvements, especially
 in the areas of UI performance, memory management and security.

JavaFX can be upgraded independently of the JDK used to build the
application, so this change is modular and does not affect other parts
of the build process.

Related / likely related to: bisq-network#350 bisq-network#2135 bisq-network#2509 bisq-network#3128 bisq-network#3307 bisq-network#3308 bisq-network#3343
bisq-network#3430 bisq-network#3657 bisq-network#3677 bisq-network#3683 bisq-network#3686 bisq-network#3786 bisq-network#3787 bisq-network#3892 bisq-network#3917 bisq-network#3918 bisq-network#3936
@cd2357
Copy link
Contributor

cd2357 commented May 9, 2021

Should be fixed in the most recent release (v1.6.4) which brings massive UI performance improvements. Please try it out and let us know if it's still an issue for you.

@cd2357 cd2357 closed this as completed May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants