Update dao image text and ids #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 9, 2020 11:46
This commit changes all text fields back to English, but next commit will fix.
Results in translated text, but looks sloppy because positioning is sloppy.
|
Tested and looks good! ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most importantly, this PR updates the
idfield for all SVG images on the DAO page so that the new translations update script introduced in #386 can work. It also refines text positioning so future changes can be applied easily.In addition, SVG text itself is updated to reflect the most recent revisions in Transifex.
To review, compare the following page across all languages to the existing https://bisq.network/dao/ page across all languages:
https://deploy-preview-385--bisq-website.netlify.app/dao/
Cross-reference any inconsistencies with the
dao_imageslist in_data/<lang>.yml.