Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Schema.org JSON-LD Microdata for SEO (FAQ page) #291

Merged
merged 9 commits into from
Nov 28, 2019

Conversation

RiccardoMasutti
Copy link
Contributor

@RiccardoMasutti RiccardoMasutti commented Nov 21, 2019

Following #290

As specified on https://developers.google.com/search/docs/data-types/faqpage

Final result:
image

@RiccardoMasutti
Copy link
Contributor Author

@m52go
Copy link
Contributor

m52go commented Nov 25, 2019

@RiccardoMasutti thanks! Two things.

  1. Could you please add these improvements to the non-English faq.html files?

  2. Could you indent the new div blocks to be consistent with the rest of the document?

Example:

  <h6 class="accordion-toggle border-top pt-3 pb-2 green" id="why-security-deposit" itemprop="name">{{ item.hSecurityDeposit }}</h6>
  <div class="accordion-content pb-5 col-sm-12 col-md-8 ml-0 pl-sm-0 pl-md-0 px-0" itemscope itemprop="acceptedAnswer" itemtype="https://schema.org/Answer">
    <div itemprop="text">
    {{ item.pSecurityDeposit }}
    </div>
  </div>
  </div>

Suggested:


  <h6 class="accordion-toggle border-top pt-3 pb-2 green" id="why-security-deposit" itemprop="name">{{ item.hSecurityDeposit }}</h6>
    <div class="accordion-content pb-5 col-sm-12 col-md-8 ml-0 pl-sm-0 pl-md-0 px-0" itemscope itemprop="acceptedAnswer" itemtype="https://schema.org/Answer">
      <div itemprop="text">
      {{ item.pSecurityDeposit }}
      </div>
    </div>
  </div>

@RiccardoMasutti
Copy link
Contributor Author

@m52go Done

Copy link
Contributor

@m52go m52go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. One item remains...please see my comment.

es/faq.html Outdated Show resolved Hide resolved
@m52go
Copy link
Contributor

m52go commented Nov 28, 2019

ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants