Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use post build plugin #7

Merged
merged 14 commits into from
Jul 26, 2022

Conversation

ghubstan
Copy link
Member

Imports pre-compiled script plugin bisq.post-build instead of custom task postBuild.

Based on #6

Fixes v 7.4.2 bug:  some misleading warnings about task dependencies
TODO Create new PR to change .gitmodules content

    [submodule "bisq-gradle"]
	    path = bisq-gradle
	    url = https://github.com/ghubstan/bisq-gradle.git
	    branch = add-post-build-task

TO

    [submodule "bisq-gradle"]
	    path = bisq-gradle
	    url = https://github.com/bisq-network/bisq-gradle.git

We need to wait until PR bisq-network/bisq-gradle#1
to be approved & merged before making the above change to .gitmdoules
TODO Test service installation again after PR merge.
TODO Test scripts with bisq-monitor service dependency
     Wating for merge (new PR) for branch
     https://github.com/ghubstan/bisq-monitor/tree/add-gradle-task-submodule
Is being replaced by bisq-network's bisq-gradle plugin because PR
bisq-network/bisq-gradle#2 has been merged.
Seems to be blocked only for me, in my region
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@bisq-github-admin-3 bisq-github-admin-3 merged commit bdb877c into bisq-network:main Jul 26, 2022
@ghubstan ghubstan deleted the use-post-build-plugin branch July 26, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants