Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build, adjust script paths, apply IDE formatting #6

Merged

Conversation

ghubstan
Copy link
Member

  • Remove google.osdetector plugin dependency

  • Upgrade to Gradle 7.5 (fixes misleading warnings about task dependencies)

  • Code formatting & style adjustments as per IDE

  • Adjust service script paths to new bisq-pricenode repo
    TODO Test service installation again after PR merge.
    TODO Test scripts with bisq-monitor service dependency
    Wating for merge (new PR) for branch
    https://github.com/ghubstan/bisq-monitor/tree/add-gradle-task-submodule

  • Make test logging configurable

  • Add git submodule bisq-gradle
    Use postBuild task in .gitmodules bisq-gradle

    TODO Create new PR to change .gitmodules content

      [submodule "bisq-gradle"]
              path = bisq-gradle
              url = https://github.com/ghubstan/bisq-gradle.git
              branch = add-post-build-task
    

    TO

      [submodule "bisq-gradle"]
              path = bisq-gradle
              url = https://github.com/bisq-network/bisq-gradle.git
    

    We need to wait until PR Add re-usable Gradle task postBuild bisq-gradle#1 is approved & merged before making the above change to .gitmdoules

Fixes v 7.4.2 bug:  some misleading warnings about task dependencies
TODO Create new PR to change .gitmodules content

    [submodule "bisq-gradle"]
	    path = bisq-gradle
	    url = https://github.com/ghubstan/bisq-gradle.git
	    branch = add-post-build-task

TO

    [submodule "bisq-gradle"]
	    path = bisq-gradle
	    url = https://github.com/bisq-network/bisq-gradle.git

We need to wait until PR bisq-network/bisq-gradle#1
to be approved & merged before making the above change to .gitmdoules
TODO Test service installation again after PR merge.
TODO Test scripts with bisq-monitor service dependency
     Wating for merge (new PR) for branch
     https://github.com/ghubstan/bisq-monitor/tree/add-gradle-task-submodule
@ghubstan ghubstan mentioned this pull request Jul 24, 2022
@bisq-github-admin-3 bisq-github-admin-3 merged commit 42255f5 into bisq-network:main Jul 26, 2022
@ghubstan ghubstan deleted the adjust-build-files-n-scripts branch July 26, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants