Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): use correct node for code action #686

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Nov 7, 2023

Summary

Closes #676

We were emitting an incorrect node with incorrect nodes; hence during the lining phase the rule could never find "noreferrer".

Test Plan

Existing tests should pass. I tested manually using the CLI, because that's where the issue occurs.

@ematipico ematipico temporarily deployed to Website deployment November 7, 2023 08:36 — with GitHub Actions Inactive
@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Nov 7, 2023
@ematipico ematipico merged commit e3fc59d into main Nov 7, 2023
17 checks passed
@ematipico ematipico deleted the fix/no-blank-target branch November 7, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 lint/a11y/noBlankTarget hangs while applying fix
1 participant