🐛 lint/a11y/noBlankTarget hangs while applying fix

[cianx]

Environment information

I have a simple react project I created with "yarn create vite", selecting  "react" and "Javascript" 

In the project directory, I run

yarn
yarn dlx @biomejs/biome init
yarn dlx @biomejs/biome check ./src

the check returns that it found 5 errors

if I run yarn dlx @biomejs/biome check ./src --apply biome hangs

What happened?

1. biome hangs, with a cpu at 100%.

Expected result

A successful check run with any fixable errors fixed

Code of Conduct

• I agree to follow Biome's Code of Conduct

[nhedger]

Hi @cianx, thanks for opening an issue.

Are you able to share a repository that reproduces this behavior?

[cianx]

I included instruction to generate the code in the bug report. If you run yarn create vite and select "react" and "javascript" you will have the code. This is template code auto generated for the project.

[nhedger]

Yes, thank you for these instructions, as they are vital.

If you allow me, I'd like to explain why providing a reproduction repository is important.

Between the moment you submit an issue, and when someone attempts to reproduce it, the skeleton on which the yarn create vite command is based may have changed. By providing a repository, you ensure that everyone has a copy of the same code, and you also help us troubleshoot faster.

Hope you understand.

[cianx]

https://github.com/cianx/biome-hang

[nhedger]

Thanks, much appreciated!

[nhedger]

I was able to narrow down the issue to the lint/a11y/noBlankTarget rule.

The following minimal reproduction produces the issue on Biome 1.3.3

function Reproduction () {
    return (
        <a href="https://vitejs.dev" target="_blank">
            <img src={viteLogo} className="logo" alt="Vite logo" />
        </a>
    )
}

Fixing the rule manually confirms that it's the one blocking the rest.

function Reproduction () {
    return (
-        <a href="https://vitejs.dev" target="_blank">
+		 <a href="https://vitejs.dev" target="_blank" rel="noreferrer">
            <img src={viteLogo} className="logo" alt="Vite logo" />
        </a>
    )
}

We seem to end up in a loop when applying the fix.

log (truncated for brevity)

biome lint --apply --log-level=debug ./test.jsx
  2023-11-06T16:04:29.511197Z DEBUG  pushing change...
    at crates/biome_rowan/src/ast/batch.rs:294 on biome::worker_5
    in Processes linting with path: "./test.jsx"

  2023-11-06T16:04:29.511250Z DEBUG  pushing change...
    at crates/biome_rowan/src/ast/batch.rs:294 on biome::worker_5
    in Processes linting with path: "./test.jsx"

  2023-11-06T16:04:29.511283Z DEBUG   changes [CommitChange { parent_depth: 10, parent: Some([email protected]), parent_range: Some((39, 93)), new_node_slot: 3, new_node: Some(Node([email protected])) }]
    at crates/biome_rowan/src/ast/batch.rs:310 on biome::worker_5
    in Processes linting with path: "./test.jsx"

  2023-11-06T16:04:29.511681Z DEBUG  pushing change...
    at crates/biome_rowan/src/ast/batch.rs:294 on biome::worker_5
    in Processes linting with path: "./test.jsx"

  2023-11-06T16:04:29.511704Z DEBUG  pushing change...
    at crates/biome_rowan/src/ast/batch.rs:294 on biome::worker_5
    in Processes linting with path: "./test.jsx"

  2023-11-06T16:04:29.511721Z DEBUG   changes [CommitChange { parent_depth: 13, parent: Some([email protected]), parent_range: Some((96, 109)), new_node_slot: 1, new_node: Some(Node([email protected])) }]
    at crates/biome_rowan/src/ast/batch.rs:310 on biome::worker_5
    in Processes linting with path: "./test.jsx"

  2023-11-06T16:04:29.512041Z DEBUG  pushing change...
    at crates/biome_rowan/src/ast/batch.rs:294 on biome::worker_5
    in Processes linting with path: "./test.jsx"

  2023-11-06T16:04:29.512059Z DEBUG  pushing change...
    at crates/biome_rowan/src/ast/batch.rs:294 on biome::worker_5
    in Processes linting with path: "./test.jsx"

  2023-11-06T16:04:29.512074Z DEBUG   changes [CommitChange { parent_depth: 13, parent: Some([email protected]), parent_range: Some((96, 122)), new_node_slot: 1, new_node: Some(Node([email protected])) }]
    at crates/biome_rowan/src/ast/batch.rs:310 on biome::worker_5
    in Processes linting with path: "./test.jsx"

  2023-11-06T16:04:29.512363Z DEBUG  pushing change...
    at crates/biome_rowan/src/ast/batch.rs:294 on biome::worker_5
    in Processes linting with path: "./test.jsx"

  2023-11-06T16:04:29.512380Z DEBUG  pushing change...
    at crates/biome_rowan/src/ast/batch.rs:294 on biome::worker_5
    in Processes linting with path: "./test.jsx"

  2023-11-06T16:04:29.512393Z DEBUG   changes [CommitChange { parent_depth: 13, parent: Some([email protected]), parent_range: Some((96, 135)), new_node_slot: 1, new_node: Some(Node([email protected])) }]
    at crates/biome_rowan/src/ast/batch.rs:310 on biome::worker_5
    in Processes linting with path: "./test.jsx"

  2023-11-06T16:04:29.512662Z DEBUG  pushing change...
    at crates/biome_rowan/src/ast/batch.rs:294 on biome::worker_5
    in Processes linting with path: "./test.jsx"

  2023-11-06T16:04:29.512678Z DEBUG  pushing change...
    at crates/biome_rowan/src/ast/batch.rs:294 on biome::worker_5
    in Processes linting with path: "./test.jsx"

[nhedger]

Applying the quick fix via VS Code works.

Screen.Recording.2023-11-06.at.21.47.06.mov