Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/useExhaustiveDependencies): ignore optional chaining #666

Merged
merged 11 commits into from
Nov 6, 2023

Conversation

msdlisper
Copy link
Contributor

Summary

fix #607

capture_text and dependency_text should filter the '?' in order to ignore optional chaining

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Nov 3, 2023
@msdlisper
Copy link
Contributor Author

msdlisper commented Nov 3, 2023

How can i fix 'LLVM ERROR: IO failure on output stream: No space left on device' in ubuntu-latest  😂

@nhedger
Copy link
Member

nhedger commented Nov 3, 2023

We could try deleting some unnecessary tools that were bundled with the ubuntu image.

There is a GitHub Actions that can do that: https://github.com/jlumbroso/free-disk-space.

Pretty sure that we could delete the Android tools and save about 14GiB.

What do you think @biomejs/core-contributors ?

@ematipico
Copy link
Member

We could try deleting some unnecessary tools that were bundled with the ubuntu image.

There is a GitHub Actions that can do that: jlumbroso/free-disk-space.

Pretty sure that we could delete the Android tools and save about 14GiB.

What do you think @biomejs/core-contributors ?

We could try. I thought the issue was around our cache.

@nhedger
Copy link
Member

nhedger commented Nov 3, 2023

Trying in #667

@msdlisper
Copy link
Contributor Author

I went to #667 to see, it has been successful, do you need me to operate here? @nhedger

@nhedger
Copy link
Member

nhedger commented Nov 3, 2023

When we merge #667, you can rebase your branch so we can check if it helps.

My PR did not actually run the tests but only updated the workflow, so it wouldn't have failed anyway.

I'll make sure to ping you when it's merged.

@nhedger nhedger changed the title Fix exhaustive dependencies (#607) fix(lint/useExhaustiveDependencies): ignore optional chaining Nov 3, 2023
@nhedger
Copy link
Member

nhedger commented Nov 4, 2023

@msdlisper, we've merged it into main.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great fix! Thank you very much

@msdlisper msdlisper requested a review from ematipico November 6, 2023 12:25
@msdlisper
Copy link
Contributor Author

@ematipico I found that this pr has not been merged, is there anything that needs to be improved:)

@ematipico ematipico merged commit b0cdf48 into biomejs:main Nov 6, 2023
14 checks passed
@nstepien
Copy link
Contributor

nstepien commented Nov 6, 2023

@msdlisper the change log was added to the already released 1.3.3 version 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 useExhaustiveDependencies: bug with optional chaining
4 participants