-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lint/useExhaustiveDependencies): ignore optional chaining #666
fix(lint/useExhaustiveDependencies): ignore optional chaining #666
Conversation
How can i fix 'LLVM ERROR: IO failure on output stream: No space left on device' in ubuntu-latest 😂 |
We could try deleting some unnecessary tools that were bundled with the ubuntu image. There is a GitHub Actions that can do that: https://github.com/jlumbroso/free-disk-space. Pretty sure that we could delete the Android tools and save about 14GiB. What do you think @biomejs/core-contributors ? |
We could try. I thought the issue was around our cache. |
Trying in #667 |
When we merge #667, you can rebase your branch so we can check if it helps. My PR did not actually run the tests but only updated the workflow, so it wouldn't have failed anyway. I'll make sure to ping you when it's merged. |
@msdlisper, we've merged it into main. |
Co-authored-by: Superchupu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great fix! Thank you very much
@ematipico I found that this pr has not been merged, is there anything that needs to be improved:) |
@msdlisper the change log was added to the already released 1.3.3 version 🙃 |
Summary
fix #607
capture_text and dependency_text should filter the '?' in order to ignore optional chaining