fix(lint/useExhaustiveDependencies): ignore optional chaining (#666)

Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Superchupu <[email protected]>
Co-authored-by: Nicolas Hedger <[email protected]>

CHANGELOG.md

@@ -85,8 +85,9 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
 - Fix [#591](https://github.com/biomejs/biome/issues/591) which made [noRedeclare](https://biomejs.dev/linter/rules/no-redeclare) report type parameters with identical names but in different method signatures. Contributed by @Conaclos
 - Support more a11y roles and fix some methods for a11y lint rules Contributed @nissy-dev
-- Fix `useExhaustiveDependencies`, by removing `useContext`, `useId` and `useSyncExternalStore` from the known hooks. Contributed by @msdlisper
--
+- Fix [#609](https://github.com/biomejs/biome/issues/609) `useExhaustiveDependencies`, by removing `useContext`, `useId` and `useSyncExternalStore` from the known hooks. Contributed by @msdlisper
+- Fix [#607](https://github.com/biomejs/biome/issues/609) `useExhaustiveDependencies`, ignore optional chaining, Contributed by @msdlisper
+
 ### Parser
 
 #### Enhancements

crates/biome_js_analyze/src/semantic_analyzers/correctness/use_exhaustive_dependencies.rs

@@ -533,8 +533,14 @@ impl Rule for UseExhaustiveDependencies {
                 let mut suggested_fix = None;
                 let mut is_captured_covered = false;
                 for (dependency_text, dependency_range) in deps.iter() {
-                    let capture_deeper_than_dependency = capture_text.starts_with(dependency_text);
-                    let dependency_deeper_than_capture = dependency_text.starts_with(capture_text);
+                    // capture_text and dependency_text should filter the "?" inside
+                    // in order to ignore optional chaining
+                    let filter_capture_text = capture_text.replace('?', "");
+                    let filter_dependency_text = dependency_text.replace('?', "");
+                    let capture_deeper_than_dependency =
+                        filter_capture_text.starts_with(&filter_dependency_text);
+                    let dependency_deeper_than_capture =
+                        filter_dependency_text.starts_with(&filter_capture_text);
                     match (
                         capture_deeper_than_dependency,
                         dependency_deeper_than_capture,
@@ -586,8 +592,14 @@ impl Rule for UseExhaustiveDependencies {
             for (dependency_text, dep_range) in deps {
                 let mut covers_any_capture = false;
                 for (capture_text, _, _) in captures.iter() {
-                    let capture_deeper_dependency = capture_text.starts_with(&dependency_text);
-                    let dependency_deeper_capture = dependency_text.starts_with(capture_text);
+                    // capture_text and dependency_text should filter the "?" inside
+                    // in order to ignore optional chaining
+                    let filter_capture_text = capture_text.replace('?', "");
+                    let filter_dependency_text = dependency_text.replace('?', "");
+                    let capture_deeper_dependency =
+                        filter_capture_text.starts_with(&filter_dependency_text);
+                    let dependency_deeper_capture =
+                        filter_dependency_text.starts_with(&filter_capture_text);
                     if capture_deeper_dependency || dependency_deeper_capture {
                         covers_any_capture = true;
                         break;

crates/biome_js_analyze/tests/specs/correctness/useExhaustiveDependencies/valid.js

@@ -1,7 +1,7 @@
 /* should not generate diagnostics */
 
 import React from "react";
-import { useEffect, useSyncExternalStore } from "react";
+import { useEffect, useSyncExternalStore, useMemo } from "react";
 import doSomething from 'a';
 
 // No captures
@@ -176,3 +176,12 @@ function MyComponent17() {
     console.log(data);
   }, [data]);
 }
+
+// https://github.com/biomejs/biome/issues/607
+function MyComponent18() {
+  const obj = Math.random() > 0.5 ? { a: 1, b: 2 } : undefined;
+
+  return useMemo(() => {
+    return obj?.a === 1 && obj.b === 2;
+  }, [obj?.a, obj?.b]);
+}

crates/biome_js_analyze/tests/specs/correctness/useExhaustiveDependencies/valid.js.snap

@@ -8,7 +8,7 @@ expression: valid.js
 /* should not generate diagnostics */
 
 import React from "react";
-import { useEffect, useSyncExternalStore } from "react";
+import { useEffect, useSyncExternalStore, useMemo } from "react";
 import doSomething from 'a';
 
 // No captures
@@ -184,6 +184,15 @@ function MyComponent17() {
   }, [data]);
 }
 
+// https://github.com/biomejs/biome/issues/607
+function MyComponent18() {
+  const obj = Math.random() > 0.5 ? { a: 1, b: 2 } : undefined;
+
+  return useMemo(() => {
+    return obj?.a === 1 && obj.b === 2;
+  }, [obj?.a, obj?.b]);
+}
+
 ```
 
 

website/src/content/docs/internals/changelog.mdx

@@ -91,8 +91,9 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
 - Fix [#591](https://github.com/biomejs/biome/issues/591) which made [noRedeclare](https://biomejs.dev/linter/rules/no-redeclare) report type parameters with identical names but in different method signatures. Contributed by @Conaclos
 - Support more a11y roles and fix some methods for a11y lint rules Contributed @nissy-dev
-- Fix `useExhaustiveDependencies`, by removing `useContext`, `useId` and `useSyncExternalStore` from the known hooks. Contributed by @msdlisper
--
+- Fix [#609](https://github.com/biomejs/biome/issues/609) `useExhaustiveDependencies`, by removing `useContext`, `useId` and `useSyncExternalStore` from the known hooks. Contributed by @msdlisper
+- Fix [#607](https://github.com/biomejs/biome/issues/609) `useExhaustiveDependencies`, ignore optional chaining, Contributed by @msdlisper
+
 ### Parser
 
 #### Enhancements