Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aria-data): add DPub and Graphics modules #4497

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

Conaclos
Copy link
Member

Summary

This PR adds the two ARIA modules I found:

To avoid confusion, I renamed aria-data to wai-aria.
I also removed the biome_aria_metadata/aria-data.json symlink because this is hard to maintain.
Instead, I added constants in the build script.

We now load the ARIA spec and its two modules, and we merge them together.
I used biome_deserialize::Merge to merge them.

Test Plan

CI must pass.

@Conaclos Conaclos requested review from a team November 10, 2024 14:26
Copy link

codspeed-hq bot commented Nov 10, 2024

CodSpeed Performance Report

Merging #4497 will not alter performance

Comparing conaclos/aria-modules (4666365) with main (fbf4b3d)

Summary

✅ 99 untouched benchmarks

@Conaclos Conaclos merged commit 95faf70 into main Nov 10, 2024
12 checks passed
@Conaclos Conaclos deleted the conaclos/aria-modules branch November 10, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant