fix(linter): improve diagnostic for noConstructorReturn (#4492)

biomejs · Nov 9, 2024 · fbf4b3d · fbf4b3d
1 parent 13904f2
commit fbf4b3d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/crates/biome_js_analyze/src/lint/correctness/no_constructor_return.rs b/crates/biome_js_analyze/src/lint/correctness/no_constructor_return.rs
@@ -81,6 +81,6 @@ impl Rule for NoConstructorReturn {
         ).detail(
             constructor.range(),
             "The constructor is here:"
-        ).note("Returning a value from a constructor is ignored."))
+        ).note("Returning a value from a constructor may confuse users of the class."))
     }
 }
diff --git a/crates/biome_js_analyze/tests/specs/correctness/noConstructorReturn/invalid.js.snap b/crates/biome_js_analyze/tests/specs/correctness/noConstructorReturn/invalid.js.snap
@@ -58,7 +58,7 @@ invalid.js:3:3 lint/correctness/noConstructorReturn ━━━━━━━━━
     5 │ }
     6 │ 
   
-  i Returning a value from a constructor is ignored.
+  i Returning a value from a constructor may confuse users of the class.
   
 
 ```
@@ -86,7 +86,7 @@ invalid.js:9:3 lint/correctness/noConstructorReturn ━━━━━━━━━
     11 │ }
     12 │ 
   
-  i Returning a value from a constructor is ignored.
+  i Returning a value from a constructor may confuse users of the class.
   
 
 ```
@@ -115,7 +115,7 @@ invalid.js:16:3 lint/correctness/noConstructorReturn ━━━━━━━━━
     18 │ }
     19 │ 
   
-  i Returning a value from a constructor is ignored.
+  i Returning a value from a constructor may confuse users of the class.
   
 
 ```
@@ -146,9 +146,7 @@ invalid.js:24:4 lint/correctness/noConstructorReturn ━━━━━━━━━
        │ 	^
     28 │ }
   
-  i Returning a value from a constructor is ignored.
+  i Returning a value from a constructor may confuse users of the class.
   
 
 ```
-
-