Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(format/html): impl non-verbatim formatting for directive and element tags #3781

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 4, 2024

Summary

This PR refactors the directive and element tag formatters to not use the verbatim formatter. This allows testing and experimentation with formatters for child tokens. Without this, it's not possible to test formatters for attribute and element lists.

Test Plan

It builds.

@dyc3 dyc3 marked this pull request as ready for review September 4, 2024 15:13
Copy link

codspeed-hq bot commented Sep 4, 2024

CodSpeed Performance Report

Merging #3781 will degrade performances by 6.19%

Comparing 09-04-feat_format_html_impl_formatting_for_directive_and_element_tags (0c1e86c) with main (b93a266)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 104 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 09-04-feat_format_html_impl_formatting_for_directive_and_element_tags Change
dojo_11880045762646467684.js[cached] 8 ms 8.6 ms -6.19%
react.production.min_3378072959512366797.js[cached] 2 ms 1.9 ms +6.84%
big5-added_15586211152145260264.json[uncached] 666.5 µs 542.5 µs +22.85%

@dyc3 dyc3 requested a review from a team September 4, 2024 16:35
@dyc3 dyc3 added the L-HTML Language: HTML label Sep 5, 2024
@dyc3 dyc3 force-pushed the 09-04-feat_format_html_impl_formatting_for_directive_and_element_tags branch 5 times, most recently from 12effb3 to 6fff245 Compare September 9, 2024 16:14
@dyc3 dyc3 force-pushed the 09-04-feat_format_html_impl_formatting_for_directive_and_element_tags branch from 6fff245 to 0c1e86c Compare September 9, 2024 16:34
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lGTM

@dyc3 dyc3 merged commit 0e54591 into main Sep 9, 2024
14 of 15 checks passed
@dyc3 dyc3 deleted the 09-04-feat_format_html_impl_formatting_for_directive_and_element_tags branch September 9, 2024 20:50
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog L-HTML Language: HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants