Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(format/html): set up test infrastructure #3798

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 5, 2024

Summary

This PR sets up everything necessary to start adding snapshot tests for the html formatter.

Test Plan

The example snapshot test works and is evaluated correctly, and importing prettier's html tests also work (I just haven't done that to make reviewing this easier).

@github-actions github-actions bot added A-Project Area: project A-Tooling Area: internal tools labels Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48511 48511 0
Passed 47320 47320 0
Failed 1191 1191 0
Panics 0 0 0
Coverage 97.54% 97.54% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6569 6569 0
Passed 2202 2202 0
Failed 4367 4367 0
Panics 0 0 0
Coverage 33.52% 33.52% 0.00%

ts/babel

Test result main count This PR count Difference
Total 671 671 0
Passed 599 599 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.27% 89.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18420 18420 0
Passed 14102 14102 0
Failed 4318 4318 0
Panics 0 0 0
Coverage 76.56% 76.56% 0.00%

@dyc3 dyc3 force-pushed the 09-05-test_format_html_set_up_test_infrastructure branch from b59fa0d to dbdf1b7 Compare September 5, 2024 19:05
Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #3798 will not alter performance

Comparing 09-05-test_format_html_set_up_test_infrastructure (1a54307) with main (a66e450)

Summary

✅ 107 untouched benchmarks

@dyc3 dyc3 force-pushed the 09-05-test_format_html_set_up_test_infrastructure branch from dbdf1b7 to 025194a Compare September 5, 2024 21:13
@dyc3 dyc3 added the L-HTML Language: HTML label Sep 5, 2024
@dyc3 dyc3 force-pushed the 09-05-test_format_html_set_up_test_infrastructure branch 2 times, most recently from 3d47c85 to 6395a04 Compare September 9, 2024 16:20
@dyc3 dyc3 force-pushed the 09-05-test_format_html_set_up_test_infrastructure branch from 6395a04 to 1a54307 Compare September 9, 2024 22:41
@dyc3 dyc3 marked this pull request as ready for review September 9, 2024 22:41
@dyc3 dyc3 requested review from a team September 10, 2024 00:52
@dyc3 dyc3 merged commit 7f02581 into main Sep 10, 2024
17 checks passed
@dyc3 dyc3 deleted the 09-05-test_format_html_set_up_test_infrastructure branch September 10, 2024 09:57
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Project Area: project A-Tooling Area: internal tools L-HTML Language: HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants