Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(noUselessEscapeInRegex): don't report unescaped range sep at the end of a class #3687

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix a false positive of noUselessEscapeInRegex.

Test Plan

I added a test.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Aug 20, 2024
@Conaclos Conaclos merged commit 7fce9af into main Aug 20, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/noUselessEscapeInRegex-false-positive branch August 20, 2024 15:58
Copy link

codspeed-hq bot commented Aug 20, 2024

CodSpeed Performance Report

Merging #3687 will degrade performances by 6.58%

Comparing conaclos/noUselessEscapeInRegex-false-positive (1fba723) with main (11956d0)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 99 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main conaclos/noUselessEscapeInRegex-false-positive Change
dojo_11880045762646467684.js[cached] 8.4 ms 7.9 ms +6.41%
react.production.min_3378072959512366797.js[cached] 1.9 ms 2 ms -6.58%

@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant