fix(noUselessEscapeInRegex): don't report unescaped range sep at the …

…end of a class (#3687)
biomejs · Aug 20, 2024 · 7fce9af · 7fce9af
1 parent 2ed2cb9
commit 7fce9af
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/crates/biome_js_analyze/src/lint/nursery/no_useless_escape_in_regex.rs b/crates/biome_js_analyze/src/lint/nursery/no_useless_escape_in_regex.rs
@@ -182,7 +182,10 @@ impl Rule for NoUselessEscapeInRegex {
                             b']' => {
                                 if has_v_flag && inner_class_count != 0 {
                                     inner_class_count -= 1;
-                                } else if !has_v_flag && bytes[index - 1] == b'-' {
+                                } else if !has_v_flag
+                                    && bytes[index - 2] == b'\\'
+                                    && bytes[index - 1] == b'-'
+                                {
                                     return Some(State {
                                         backslash_index: (index - 2) as u16,
                                         escaped: b'-',

diff --git a/crates/biome_js_analyze/tests/specs/nursery/noUselessEscapeInRegex/valid.js b/crates/biome_js_analyze/tests/specs/nursery/noUselessEscapeInRegex/valid.js
@@ -94,4 +94,6 @@
 /[_^\^]/v;
 /[\&&&\&]/v;
 /[[\-]\-]/v;
-/[\^]/v;
+/[\^]/v;
+
+/[z-]/;
diff --git a/crates/biome_js_analyze/tests/specs/nursery/noUselessEscapeInRegex/valid.js.snap b/crates/biome_js_analyze/tests/specs/nursery/noUselessEscapeInRegex/valid.js.snap
@@ -101,4 +101,7 @@ expression: valid.js
 /[\&&&\&]/v;
 /[[\-]\-]/v;
 /[\^]/v;
+
+/[z-]/;
+
 ```