-
-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(linter): allow multiple rule sources #2336
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
Can you explain how these multiple sources would be displayed and explained to the user in https://biomejs.dev/linter/rules-sources/? |
CodSpeed Performance ReportMerging #2336 will not alter performanceComparing Summary
|
I didn't change the way of generating the page. Basically several rules can point to the same Biome rule. |
Wouldn't you want to display this information to the users? |
Have you something in mind? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having the same Biome rule appear multiple times on the right-hand side on that page is fine.
Summary
This PR allows specifying several sources for a rule.
We assume that every source has the same source kind.
I also updated the rule metadata and I changed the data structure used by
migrate eslint
in order to preserve the order of rules.This order is important because a rule may override another rule if they have the same source.
Test Plan
I added a test for testing the migration with several rules that share the same Biome rule.