feat(biome_js_analyze): noFlatMapIdentity

[isnakode]

Summary

Close #2303.

this PR adds lint support to replace unnecessary flatMap call with flat instead, maybe need some help to refine the diagnostic message (my english is so bad)

Test Plan

manually tested

[netlify]

✅ Deploy Preview for biomejs ready!

Name	Link
🔨 Latest commit	9659d9f
🔍 Latest deploy log	https://app.netlify.com/sites/biomejs/deploys/661be235d8bc020008b6c5a1
😎 Deploy Preview	https://deploy-preview-2324--biomejs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🔴 down 3 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 93 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codspeed-hq]

CodSpeed Performance Report

Merging #2324 will improve performances by 13.33%

_{Comparing isnakode:main (9659d9f) with main (75af801)}

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	isnakode:main	Change
⚡	eucjp.json[uncached]	5.6 ms	4.9 ms	+13.33%

[isnakode]

i've update the PR

[unvalley]

I think we can merge this after fixing the consistency of the wording regarding periods. Thank you for contribution!

[unvalley]

@isnakode looks good to me, could you execute just gen-all?

EDIT: and please write changelog.

[isnakode]

nah, how to write changelog?, any link?

[unvalley]

@isnakode We have the CHANGELOG.md at root. You can add the Unreleased/Linter/New features section, please refer to other lint rules addition.

[ematipico]

nah, how to write changelog?, any link?

https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md

There's a whole section about the changelog

[isnakode]

done

[ematipico]

@isnakode please pull this branch again and make just ready success.

We don't recommend just ready anymore, because it does too much. I think I started to remove it, or suggesting commands related to the area the contributor is working on

[Sec-ant]

LGTM, but we should add more test cases.

[Conaclos]

Let's follow the rule pillars:

• show the error
• explain why it could be an error
• suggest a solution (Code action)

[Sec-ant]

@isnakode I did some tweak on your branch for it to pass the CI:

1. Rule sources 43eeeba, address feat(biome_js_analyze): noFlatMapIdentity #2324 (comment)
2. Run just gen-lint to update the rule doc and schemas 710f628
3. Update the snapshots. I think you're on a windows machine so the snapshots contain carriage returns that will fail the CI check. I removed them. 584d5bf

Run git pull to update your local branch.

[Sec-ant]

git pull maybe the wrong suggestion because that introduces some conflicts again. 😅 So I update them again. If you want to sync your local repo with the remote one, in your local repo main branch:

git fetch origin
git reset --hard origin/main

[isnakode]

okay, should i push directly after it, or what?

[Sec-ant]

okay, should i push directly after it, or what?

Yep, you can push more commits from now on. But the carriage returns may be added back if you run the tests and update the snapshots again. That may need some settings or manual removal. 🤔

[Conaclos]

Thanks for your contribution! You made it!
This will part of the tomorrow's release :)