Fix/arrowfunction with conditional expression body #1929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1805
I found an incompatibility issue with Prettier when using arrow functions which body is conditional expression
I found this issue occurs when formatting arrow functions whose body is conditional expression
see below example code when linewidth 17
playground
I found prettier enforce space after
=>
this token in this case.And I tried to implement this without changing to FormatElement but failed. So, I added a
HardSpace
toFormatElement
to implement this.I am not sure if this approach is acceptable.
Also Documenting can be quite challenging.
Please review my code
Test Plan
add test case