Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Inconsistency compared to prettier #1805

Closed
1 task done
xXNickznXx opened this issue Feb 13, 2024 · 3 comments · Fixed by #1929
Closed
1 task done

📝 Inconsistency compared to prettier #1805

xXNickznXx opened this issue Feb 13, 2024 · 3 comments · Fixed by #1929
Assignees
Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@xXNickznXx
Copy link

Environment information

CLI:
  Version:                      1.5.3
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         unset
  JS_RUNTIME_VERSION:           "v20.9.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/10.1.0"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Configuration

{
  "$schema": "https://biomejs.dev/schemas/1.5.3/schema.json",
  "javascript": {
    "formatter": {
      "quoteStyle": "single",
      "trailingComma": "none"
    }
  },
  "formatter": {
    "indentStyle": "space",
    "lineEnding": "crlf",
    "lineWidth": 140
  }
}

Playground link

https://biomejs.dev/playground/?lineWidth=140&indentStyle=space&quoteStyle=single&trailingComma=none&typescript=false&code=ZgB1AG4AYwB0AGkAbwBuACAAYQAoACkAIAB7AAoAIAAgAGkAZgAgACgAdAByAHUAZQApACAAewAKACAAIAAgACAAYwBvAG4AcwB0ACAAdwBhAGwAawBlAHIAQwBoAGkAbABkAHIAZQBuAFcAaQB0AGgAUQB1AG8AdABhAHQAaQBvAG4ATQBhAHIAawAgAD0AIABkAG8AYwB1AG0AZQBuAHQALgBjAHIAZQBhAHQAZQBUAHIAZQBlAFcAYQBsAGsAZQByACgACgAgACAAIAAgACAAIAB0AGgAaQBzAC4AdABlAHgAdABDAG8AbgB0AGUAbgB0AEUAbABlAG0AZQBuAHQALgBuAGEAdABpAHYAZQBFAGwAZQBtAGUAbgB0ACwACgAgACAAIAAgACAAIABOAG8AZABlAEYAaQBsAHQAZQByAC4AUwBIAE8AVwBfAFQARQBYAFQALAAKACAAIAAgACAAIAAgACgAbgBvAGQAZQApACAAPQA%2BACAAKABEAEkAUwBBAEwATABPAFcARQBEAF8AUQBVAE8AVABFAFMALgBzAG8AbQBlACgAKABzACkAIAA9AD4AIABuAG8AZABlAC4AdABlAHgAdABDAG8AbgB0AGUAbgB0AC4AaQBuAGMAbAB1AGQAZQBzACgAcwApACkAIAA%2FACAATgBvAGQAZQBGAGkAbAB0AGUAcgAuAEYASQBMAFQARQBSAF8AQQBDAEMARQBQAFQAIAA6ACAATgBvAGQAZQBGAGkAbAB0AGUAcgAuAEYASQBMAFQARQBSAF8AUwBLAEkAUAApAAoAIAAgACAAIAApADsACgAgACAAfQAKAH0ACgA%3D

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Conaclos Conaclos added A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project labels Feb 13, 2024
@mdm317
Copy link
Contributor

mdm317 commented Feb 17, 2024

Can i try this issue?

@togami2864
Copy link
Contributor

Hi @mdm317. I've previously looked into this issue and discovered something that might be helpful:)

  • The inconsistency appears only when line-width is set to 140
  • The length of the following line in reproduction code is just 140
     const walkerChildrenWithQuotationMark = document.createTreeWalker(this.textContentElement.nativeElement, NodeFilter.SHOW_TEXT, (node) =>

@mdm317
Copy link
Contributor

mdm317 commented Feb 17, 2024

@togami2864
Thank you! It seems like it will be a great help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants