fix(lint/useForOf): handle shorthand property

CHANGELOG.md

@@ -74,6 +74,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
 - Fix [#1640](https://github.com/biomejs/biome/issues/1640). [useEnumInitializers](https://biomejs.dev/linter/rules/use-enum-initializers) code action now generates valid code when last member has a comment but no comma. Contributed by @kalleep
 
+- Fix [#1653](https://github.com/biomejs/biome/issues/1653). Handle a shorthand value in `useForOf` to avoid the false-positive case. Contributed by @togami2864
+
 ### Parser
 
 ## 1.5.3 (2024-01-22)

crates/biome_js_analyze/src/semantic_analyzers/nursery/use_for_of.rs

@@ -2,10 +2,11 @@ use biome_analyze::{context::RuleContext, declare_rule, Rule, RuleDiagnostic, Ru
 use biome_console::markup;
 use biome_js_semantic::{ReferencesExtensions, SemanticModel};
 use biome_js_syntax::{
-    AnyJsExpression, AnyJsForInitializer, AnyJsStatement, JsAssignmentExpression,
-    JsAssignmentOperator, JsBinaryExpression, JsBinaryOperator, JsForStatement,
-    JsIdentifierBinding, JsIdentifierExpression, JsPostUpdateExpression, JsPostUpdateOperator,
-    JsPreUpdateExpression, JsPreUpdateOperator, JsSyntaxKind, JsSyntaxToken, JsUnaryOperator,
+    AnyJsExpression, AnyJsForInitializer, AnyJsObjectMember, AnyJsStatement,
+    JsAssignmentExpression, JsAssignmentOperator, JsBinaryExpression, JsBinaryOperator,
+    JsForStatement, JsIdentifierBinding, JsIdentifierExpression, JsPostUpdateExpression,
+    JsPostUpdateOperator, JsPreUpdateExpression, JsPreUpdateOperator,
+    JsShorthandPropertyObjectMember, JsSyntaxKind, JsSyntaxToken, JsUnaryOperator,
     JsVariableDeclarator,
 };
 use biome_rowan::{declare_node_union, AstNode, AstSeparatedList, TextRange};
@@ -52,7 +53,7 @@ declare_node_union! {
 }
 
 declare_node_union! {
-    pub(crate) AnyBindingExpression = JsPostUpdateExpression | JsPreUpdateExpression | JsIdentifierExpression
+    pub(crate) AnyBindingExpression = JsPostUpdateExpression | JsPreUpdateExpression | JsIdentifierExpression | JsShorthandPropertyObjectMember
 }
 
 impl Rule for UseForOf {
@@ -99,15 +100,13 @@ impl Rule for UseForOf {
             .as_js_static_member_expression()?
             .object()
             .ok()?;
-
         let index_only_used_with_array = |reference| {
             let array_in_use = reference_being_used_by_array(reference, &array_used_in_for)
                 .is_some_and(|array_in_use| array_in_use);
             let is_delete = is_delete(reference).is_some_and(|is_delete| is_delete);
 
             array_in_use && !is_delete
         };
-
         if references.iter().all(index_only_used_with_array) {
             Some(())
         } else {
@@ -147,6 +146,12 @@ fn list_initializer_references(
                 return None;
             }
 
+            if let Some(AnyJsObjectMember::JsShorthandPropertyObjectMember(expr)) =
+                AnyJsObjectMember::cast(reference.syntax().parent()?)
+            {
+                return Some(AnyBindingExpression::from(expr));
+            }
+
             AnyBindingExpression::try_from(AnyJsExpression::cast(reference.syntax().parent()?)?)
                 .ok()
         })

crates/biome_js_analyze/tests/specs/nursery/useForOf/valid.js

@@ -12,6 +12,10 @@ for (let i = 0; i < arr.length; i++) {
   arr[i] = 0;
 }
 
+for (let i = 0; i < array.length; i++) {
+  console.log({ i });
+}
+
 for (var c = 0; c < arr.length; c++) {
   doMath(c);
 }

crates/biome_js_analyze/tests/specs/nursery/useForOf/valid.js.snap

@@ -18,6 +18,10 @@ for (let i = 0; i < arr.length; i++) {
   arr[i] = 0;
 }
 
+for (let i = 0; i < array.length; i++) {
+  console.log({ i });
+}
+
 for (var c = 0; c < arr.length; c++) {
   doMath(c);
 }

website/src/content/docs/internals/changelog.mdx

@@ -80,6 +80,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
 - Fix [#1640](https://github.com/biomejs/biome/issues/1640). [useEnumInitializers](https://biomejs.dev/linter/rules/use-enum-initializers) code action now generates valid code when last member has a comment but no comma. Contributed by @kalleep
 
+- Fix [#1653](https://github.com/biomejs/biome/issues/1653). Handle a shorthand value in `useForOf` to avoid the false-positive case. Contributed by @togami2864
+
 ### Parser
 
 ## 1.5.3 (2024-01-22)