Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/useForOf): handle shorthand property #1666

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

togami2864
Copy link
Contributor

Summary

close #1653

Test Plan

add snaps for cases

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 5718290
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65b399c49985330008bf8555
😎 Deploy Preview https://deploy-preview-1666--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jan 25, 2024
@Conaclos
Copy link
Member

Conaclos commented Jan 25, 2024

Looks good! Would you mind adding a changelog entry?

Copy link

codspeed-hq bot commented Jan 25, 2024

CodSpeed Performance Report

Merging #1666 will not alter performance

⚠️ No base runs were found

Falling back to comparing togami2864:fix/1653 (5718290) with main (ee013e5)

Summary

✅ 93 untouched benchmarks

@github-actions github-actions bot added A-Website Area: website A-Changelog Area: changelog labels Jan 26, 2024
@Conaclos Conaclos changed the title fix: handle shorthand property fix(lint/useForOf): handle shorthand property Jan 26, 2024
crates/biome_js_analyze/src/lib.rs Outdated Show resolved Hide resolved
@Conaclos Conaclos merged commit 9aece50 into biomejs:main Jan 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 useForOf - false-positive when using index as a shorthand value
2 participants