Use the LSP from workspace #9
Conversation
| !f["dependencies"]["@biomejs/biome"].is_null() | ||
| || !f["devDependencies"]["@biomejs/biome"].is_null() |
There was a problem hiding this comment.
Wouldn't this error if dependencies or devDependencies fields aren't inside the package.json?
There was a problem hiding this comment.
I tested a bit, it will return null if one of the fields is non-existent. But feel free to test it again.
| // This is a workaround, as reading the file from wasm doesn't work. | ||
| // Instead we try to read the `package.json`, see if `@biomejs/biome` is installed | ||
| let package_json = worktree | ||
| .read_text_file("package.json") |
There was a problem hiding this comment.
Check the existence of the LSP binary in the workspace with fs::metadata doesn't work, probably because of wasm. Instead, we can read the package.json with worktree::read_text_file and find out if the user has included the @biomejs/biome as part of dependencies or devDependencies.
Originally I was trying to read the node_modules/@biomejs/biome/package.json with worktree::read_text_file, just to check if the user already installed the package, but it doesn't work for some reason.
The extension will use the LSP in the workspace (installed by the user), and then fallback to the default LSP if it doesn't exist.
Related #6