Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the LSP from workspace in language extension #10760

Open
1 task done
chungweileong94 opened this issue Apr 19, 2024 · 1 comment
Open
1 task done

Load the LSP from workspace in language extension #10760

chungweileong94 opened this issue Apr 19, 2024 · 1 comment
Labels
enhancement [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc language server An umbrella label for all language servers

Comments

@chungweileong94
Copy link
Contributor

Check for existing issues

  • Completed

Describe the feature

Some extension needs to load the LSP installed in the workspace, if not fallback to the global installed LSP.

For example:
The biome extension needs to be able to load the LSP binary installed in the workspace, if not install and fallback to a global LSP binary.

However, it doesn't seem like we are able to check if an LSP binary exists in the workspace, as things like Path::exists don't really work (probably because of wasm?).

I also tried to use worktree.read_text_file() to see if the node_modules/@biomejs/biome/package.json exists in the workspace, it works sometimes but mostly doesn't work. biomejs/biome-zed#9

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@chungweileong94 chungweileong94 added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Apr 19, 2024
@JosephTLyons JosephTLyons added language server An umbrella label for all language servers extension infrastructure Feedback for extensions APIs, creation, management, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Apr 19, 2024
@jansol
Copy link
Contributor

jansol commented Apr 20, 2024

AIUI this is also necessary for Android development where you need a project-specific version of gradle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc language server An umbrella label for all language servers
Projects
None yet
Development

No branches or pull requests

3 participants