-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utility function for adding additional weight formats to model spec #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FynnBe This adds another utility functionality to add weight formats to an existing model, and a workaround caused by the inconsistent serialization of raw_nodes, see #118.
In addition, the current code does not allow "model.yaml" as valid name, however this is expected by the zenodo uploader from @oeway. It would be nice to converge on something that works for the uploader.
The test failures are due to the fact that model yaml names are currently not checked.
Can we only support .yaml not .yml, I read it somewhere said it's recommended to use .yaml. |
Fine with me. |
fine with me, too, but I would suggest to leave that for 0.4.0. |
build all raw_node objects
remove empty default (None, [], {})
after resolving #119 (comment) this PR should looks ready to merge to me |
No description provided.