Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 0.3.2 tag #114

Closed
constantinpape opened this issue Jun 14, 2021 · 8 comments · Fixed by #161
Closed

Move 0.3.2 tag #114

constantinpape opened this issue Jun 14, 2021 · 8 comments · Fixed by #161

Comments

@constantinpape
Copy link
Collaborator

constantinpape commented Jun 14, 2021

I think the 0.3.2 release was made pre-maturely and we need to move it due to:

  • It did not have CI and the tests actually did not pass due to remaining issues in the spec, see add tox gh workflow #103
  • Parts of the python functionality did not work yet and are still not fully working, see What happened to spec.load_and_resolve_spec? #108
  • The validator uses marshmallow to validate the rdf instead of jsonschema, which will make all current rdfs fail, see expanding validator and auto-conversion #107. (Note that we are discussing switching to marshmallow as the reference for the rdf as well, BUT that requires a minor version bump.) (Also it' fine to validate with marshmallow, but we need to make sure that we are compliant with the current rdf spec.)
@FynnBe
Copy link
Member

FynnBe commented Jun 14, 2021

sorry, for I may have been the one with the trigger happy mouse on that release button 🙄

@constantinpape
Copy link
Collaborator Author

sorry, for I may have been the one with the trigger happy mouse on that release button roll_eyes

No worries. I think we were all eager to get this one out...

@constantinpape
Copy link
Collaborator Author

I found some additional bugs #118, #117 that should be fixed before the release.
Any chance you could fix this soon, @FynnBe?

@FynnBe
Copy link
Member

FynnBe commented Jun 15, 2021

I found some additional bugs #118, #117 that should be fixed before the release.
Any chance you could fix this soon, @FynnBe?

Luckily these might be material for discussions and explanations (and documentation) rather than fixes... (see comments in issues)

@constantinpape
Copy link
Collaborator Author

Luckily these might be material for discussions and explanations (and documentation) rather than fixes...

Yes, this is resolved now. (Though I think that #118 is very confusing design, but I can work around it, see #119).
What's still to do before moving the tag:

@FynnBe
Copy link
Member

FynnBe commented Jun 16, 2021

Update the validator so that the current rdfs pass (we should do it in marshmallow directly, given that we decided to also have the reference rdf spec there)

I'll take a look at that tomorrow.

@constantinpape
Copy link
Collaborator Author

Update the validator so that the current rdfs pass (we should do it in marshmallow directly, given that we decided to also have the reference rdf spec there)

I'll take a look at that tomorrow.

@FynnBe have we implemented this yet? It would be good to go ahead with the release before pushing anything to conda.

@FynnBe
Copy link
Member

FynnBe commented Jun 22, 2021

@FynnBe have we implemented this yet? It would be good to go ahead with the release before pushing anything to conda.

almost ready to go: #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants