Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing naming schemes for loci and sampleID #29

Merged
merged 4 commits into from
Jun 19, 2020
Merged

Fixing naming schemes for loci and sampleID #29

merged 4 commits into from
Jun 19, 2020

Conversation

rnmitchell
Copy link
Contributor

Fixes for Issue #28
-fixed space issue in pentaE/D (did this in the annotate command instead of format as mentioned in the Issue description)
-changed all loci to upper case
-subbed in _ for spaces in sampleID

@rnmitchell
Copy link
Contributor Author

This is a short one, @standage but ready for your review. Mostly minor fixes to ensure there aren't any spaces in sample/project/analysis ID names and to change locus names to be consistent with EuroForMix requirements for input.

@rnmitchell rnmitchell marked this pull request as ready for review June 19, 2020 13:26
@rnmitchell rnmitchell requested a review from standage June 19, 2020 13:27
Copy link
Member

@standage standage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward and reasonable. Looks good!

@standage standage changed the title WIP: fixing naming schemes for loci and sampleID Fixing naming schemes for loci and sampleID Jun 19, 2020
@standage standage merged commit 787add6 into master Jun 19, 2020
@standage standage deleted the names branch June 19, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants