Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Version constraints can start with ! as well #919

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix: Version constraints can start with ! as well #919

merged 2 commits into from
Sep 28, 2023

Conversation

corneliusroemer
Copy link
Member

@corneliusroemer corneliusroemer commented Sep 20, 2023 •
edited
Loading

Resolves #918

@corneliusroemer corneliusroemer changed the title Add failing test Failing test for #918 Sep 20, 2023
@corneliusroemer corneliusroemer mentioned this pull request Sep 20, 2023
Closed
@corneliusroemer corneliusroemer changed the title Failing test for #918 fix: Version constraints can start with ! as well Sep 20, 2023
@corneliusroemer corneliusroemer marked this pull request as ready for review September 20, 2023 15:20
@corneliusroemer corneliusroemer mentioned this pull request Sep 20, 2023
Merged
@corneliusroemer
Copy link
Member Author

Review and release would be great @johanneskoester @bgruening @cbrueffer @dpryan79 🙏

@bgruening
Copy link
Member

Thanks for adding the test as well!

@bgruening bgruening merged commit ee56f6e into bioconda:master Sep 28, 2023
10 of 11 checks passed
johanneskoester pushed a commit that referenced this pull request Oct 4, 2023
@github-actions
chore: release 2.5.0 (#920)
1009e8c 
🤖 I have created a release \*beep\* \*boop\*
---
##
[2.5.0](https://www.github.com/bioconda/bioconda-utils/compare/v2.4.0...v2.5.0)
(2023-10-04)


### Features

* add special lints for bioconda-repodata-patches recipe
([#855](https://www.github.com/bioconda/bioconda-utils/issues/855))
([11c9229](https://www.github.com/bioconda/bioconda-utils/commit/11c92296bbc566fcd481ea45c4d55247b4ba154d))


### Bug Fixes

* adding "vals" to GithubRelease changes for API and expanded assets
([#912](https://www.github.com/bioconda/bioconda-utils/issues/912))
([9e0e445](https://www.github.com/bioconda/bioconda-utils/commit/9e0e44581cade8d994a5b923964df060122b7519))
* Remove htslib build pinning
([#917](https://www.github.com/bioconda/bioconda-utils/issues/917))
([c7efb92](https://www.github.com/bioconda/bioconda-utils/commit/c7efb9250312abdcfbdc10be60b5a0fa92e52726))
* Version constraints can start with `!` as well
([#919](https://www.github.com/bioconda/bioconda-utils/issues/919))
([ee56f6e](https://www.github.com/bioconda/bioconda-utils/commit/ee56f6e1d20aa7c96f150ff79a084faf0521e70b)),
closes [#918](https://www.github.com/bioconda/bioconda-utils/issues/918)


### Documentation

* try to clarify some confusion with run_exports.
([#914](https://www.github.com/bioconda/bioconda-utils/issues/914))
([417e7da](https://www.github.com/bioconda/bioconda-utils/commit/417e7da6524c71ac0aafdcd75244bd001de17efd))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive lint version_constraints_missing_whitespacewhen for unequal constraint !=
2 participants
@corneliusroemer @bgruening