Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive lint version_constraints_missing_whitespacewhen for unequal constraint != #918

Closed
corneliusroemer opened this issue Sep 20, 2023 · 1 comment · Fixed by #919
Closed

False positive lint version_constraints_missing_whitespacewhen for unequal constraint != #918

corneliusroemer opened this issue Sep 20, 2023 · 1 comment · Fixed by #919

Comments

@corneliusroemer
Copy link
Member

bioconda-utils lint wrongly throws an error for a version constraint with !=:

requirements:
  run:
    - fsspec !=2023.9.1
ERROR: recipes/nextstrain-cli/meta.yaml:45: version_constraints_missing_whitespace: Packages and their version constraints must be space sepa

This was noticed in bioconda/bioconda-recipes#43160
@corneliusroemer corneliusroemer mentioned this issue Sep 20, 2023
Merged
@corneliusroemer
Copy link
Member Author

You can find a failing test in #919

bgruening pushed a commit that referenced this issue Sep 28, 2023
@corneliusroemer
fix: Version constraints can start with ! as well (#919)
ee56f6e 
Resolves #918
johanneskoester pushed a commit that referenced this issue Oct 4, 2023
@github-actions
chore: release 2.5.0 (#920)
1009e8c 
🤖 I have created a release \*beep\* \*boop\*
---
##
[2.5.0](https://www.github.com/bioconda/bioconda-utils/compare/v2.4.0...v2.5.0)
(2023-10-04)


### Features

* add special lints for bioconda-repodata-patches recipe
([#855](https://www.github.com/bioconda/bioconda-utils/issues/855))
([11c9229](https://www.github.com/bioconda/bioconda-utils/commit/11c92296bbc566fcd481ea45c4d55247b4ba154d))


### Bug Fixes

* adding "vals" to GithubRelease changes for API and expanded assets
([#912](https://www.github.com/bioconda/bioconda-utils/issues/912))
([9e0e445](https://www.github.com/bioconda/bioconda-utils/commit/9e0e44581cade8d994a5b923964df060122b7519))
* Remove htslib build pinning
([#917](https://www.github.com/bioconda/bioconda-utils/issues/917))
([c7efb92](https://www.github.com/bioconda/bioconda-utils/commit/c7efb9250312abdcfbdc10be60b5a0fa92e52726))
* Version constraints can start with `!` as well
([#919](https://www.github.com/bioconda/bioconda-utils/issues/919))
([ee56f6e](https://www.github.com/bioconda/bioconda-utils/commit/ee56f6e1d20aa7c96f150ff79a084faf0521e70b)),
closes [#918](https://www.github.com/bioconda/bioconda-utils/issues/918)


### Documentation

* try to clarify some confusion with run_exports.
([#914](https://www.github.com/bioconda/bioconda-utils/issues/914))
([417e7da](https://www.github.com/bioconda/bioconda-utils/commit/417e7da6524c71ac0aafdcd75244bd001de17efd))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Version constraints can start with ! as well corneliusroemer/bioconda-utils
1 participant
@corneliusroemer