update gempipe to v1.37.3 #52164
update gempipe to v1.37.3 #52164
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request includes updates to the Possibly related PRs
Suggested labels
Suggested reviewers
Warning Rate limit exceeded@mencian has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 43 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
recipes/gempipe/meta.yaml (1)
82-82: Remove trailing spacesThere are trailing spaces at the end of line 82.
- +🧰 Tools
🪛 yamllint
[error] 82-82: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/gempipe/meta.yaml(4 hunks)
🧰 Additional context used
🪛 yamllint
recipes/gempipe/meta.yaml
[error] 82-82: trailing spaces
(trailing-spaces)
🔇 Additional comments (4)
recipes/gempipe/meta.yaml (4)
2-2: LGTM: Version update to 1.37.3
75-75: LGTM: Documentation URL format update
The addition of trailing slash to the documentation URL is a valid improvement.
54-54: Verify seaborn package rename
The dependency has been changed from seaborn-base to seaborn. This change needs verification to ensure it's intentional and follows Conda packaging guidelines.
✅ Verification successful
The previous script didn't correctly search for seaborn packages. Let me try again with a more focused search.
Change from seaborn-base to seaborn is correct and follows current practices
The change from seaborn-base to seaborn is valid because:
- Both packages exist in conda-forge, with
seabornbeing the primary package - The majority of recipes in the repository use
seabornrather thanseaborn-base - The version requirement (>=0.13.0) is available in both packages
- Recent recipes tend to use
seabornoverseaborn-base, indicating this is the preferred package name
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify seaborn package naming convention
# Check if other recipes use seaborn or seaborn-base
rg --type yaml "seaborn.*>=.*" recipes/
# Check if seaborn package exists in conda-forge
curl -s https://conda.anaconda.org/conda-forge/noarch/repodata.json | jq '.packages | keys[] | select(startswith("seaborn"))'
Length of output: 2681
Script:
#!/bin/bash
# Search for seaborn dependencies in yaml files
rg --type yaml "seaborn.*" recipes/
# Check conda-forge for seaborn packages specifically
curl -s "https://api.anaconda.org/package/conda-forge/seaborn" -H "accept: application/json" | jq '.versions[]' -r
# Also check for seaborn-base
curl -s "https://api.anaconda.org/package/conda-forge/seaborn-base" -H "accept: application/json" | jq '.versions[]' -r
Length of output: 12175
11-15: Verify GitHub release and checksum
The source has been changed from PyPI to GitHub releases. Let's verify:
- The GitHub release exists
- The checksum is correct for the release tarball
recipes/gempipe/meta.yaml
Outdated
| - poetry >=1.7.1 | ||
| - poetry-core >=1.8.1 | ||
| - ipython >=8.7.0 |
There was a problem hiding this comment.
💡 Codebase verification
Based on the search results, I can generate the final response now:
Poetry dependencies need adjustment
The codebase analysis shows that most recipes use either poetry or poetry-core, but rarely both. When poetry is used as a dependency, it's typically for build automation and CLI tools, while poetry-core is used for build backend functionality. Since this is a recipe, poetry-core alone should be sufficient as the build backend.
- Remove
poetry >=1.7.1as it's not typically needed as a runtime dependency - Keep
poetry-core >=1.8.1for build backend support
🔗 Analysis chain
Verify poetry dependencies compatibility
The addition of both poetry and poetry-core with specific version constraints needs verification:
- Are these versions compatible with each other?
- Is
poetryneeded in addition topoetry-core?
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check poetry and poetry-core compatibility
# Search for any existing poetry configurations
fd -e pyproject.toml -x cat {} \; | grep -A 5 "\[build-system\]"
# Check if other recipes use both poetry and poetry-core
rg --type yaml "poetry.*>=.*" recipes/
Length of output: 2681
|
@BiocondaBot please add label |
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.