Pinning ggplot2 version #52124
Pinning ggplot2 version #52124
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/merqury/meta.yaml (1)
25-25: Consider long-term maintenance strategyWhile version pinning solves the immediate compatibility issues, consider:
- Creating an issue to track the needed updates for compatibility with newer ggplot2 versions
- Adding comments in the meta.yaml explaining why this version range was chosen
- Planning for future updates to handle the deprecated arguments
This will help future maintainers understand the constraints and plan for updates.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/merqury/meta.yaml(2 hunks)
🔇 Additional comments (2)
recipes/merqury/meta.yaml (2)
Line range hint 14-18: LGTM: Build configuration follows best practices
The build number increment and run_exports configuration are correctly implemented following Bioconda guidelines.
25-25: Version constraint is appropriate given the reported issues
The pinning of r-ggplot2 to versions between 3.3.2 and 3.3.6 addresses the reported issues with newer versions (coord_cartesian() and deprecated arguments).
Let's verify the availability of these versions in Bioconda:
✅ Verification successful
Version constraint is well-supported in conda-forge
The specified version range (>=3.3.2,<=3.3.6) is fully available in conda-forge with builds for multiple R versions (3.6, 4.0, 4.1, 4.2), making this constraint both appropriate and practical.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify r-ggplot2 version availability in Bioconda
# Check if the specified version range is available in bioconda
curl -s https://conda.anaconda.org/bioconda/noarch/repodata.json | \
jq '.packages | with_entries(select(.key | contains("r-ggplot2"))) | keys[]' | \
grep -E "3\.3\.[2-6]"
# Also check conda-forge as it's a common source for R packages
curl -s https://conda.anaconda.org/conda-forge/noarch/repodata.json | \
jq '.packages | with_entries(select(.key | contains("r-ggplot2"))) | keys[]' | \
grep -E "3\.3\.[2-6]"
Length of output: 942
|
@BiocondaBot please add label |
Describe your pull request here
Pinning
ggplot2versions since, with newer versions, it gives error:Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.