Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use openjdk <=21 for hmftools-redux #52122

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Use openjdk <=21 for hmftools-redux #52122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions recipes/hmftools-redux/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ source:

build:
noarch: generic
number: 5
number: 6
run_exports:
- {{ pin_subpackage('hmftools-redux', max_pin="x.x") }}

requirements:
run:
- openjdk >=8
- openjdk >=8,<=21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Java version constraint needs adjustment

Based on the upstream source code and recent commits, the Java version constraint should be adjusted. The upstream project explicitly sets Java 11 as the target version in its parent pom.xml (<java.version>11</java.version>), and there's a recent commit "INFRA-541 Redux: Use openjdk 11" specifically for this tool.

  • The current constraint >=8,<=21 should be changed to >=11,<=21 to align with the upstream requirements.
🔗 Analysis chain

Verify Java version compatibility with upstream

The addition of the upper bound <=21 for OpenJDK is a good practice to prevent potential compatibility issues with future Java versions. However, let's verify this constraint against upstream requirements.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify Java version compatibility with upstream project

# Check if there are any Java version requirements mentioned in the upstream repository
gh api repos/hartwigmedical/hmftools/contents/redux/README.md 2>/dev/null | jq -r '.content' | base64 -d | grep -i "java" || true
gh api repos/hartwigmedical/hmftools/contents/redux/pom.xml 2>/dev/null | jq -r '.content' | base64 -d | grep -i "<java.version>" || true

# Check for any Java version related issues or discussions
gh api search/issues -X GET -f q="repo:hartwigmedical/hmftools java version redux" | jq '.items[] | select(.title | test("(?i)java|jdk")) | {title: .title, url: .html_url}'

Length of output: 562

Script:

#!/bin/bash
# Let's try a different approach using direct GitHub API calls and processing the response differently

# Check pom.xml for Java version
gh api repos/hartwigmedical/hmftools/contents/redux/pom.xml | jq -r '.download_url' | xargs curl -s | grep -i "<java.version>"

# Check README.md for Java requirements
gh api repos/hartwigmedical/hmftools/contents/redux/README.md | jq -r '.download_url' | xargs curl -s | grep -i "java"

# Check for maven compiler plugin configuration which often specifies Java version
gh api repos/hartwigmedical/hmftools/contents/redux/pom.xml | jq -r '.download_url' | xargs curl -s | grep -A 5 -B 5 "maven-compiler-plugin"

Length of output: 835

Script:

#!/bin/bash
# Let's check the parent pom.xml for Java version properties
gh api repos/hartwigmedical/hmftools/contents/pom.xml | jq -r '.download_url' | xargs curl -s | grep -A 2 -B 2 "maven.compiler\|java.version"

# Also check if there are any recent commits mentioning Java version changes
gh api repos/hartwigmedical/hmftools/commits --paginate | jq -r '.[] | select(.commit.message | test("(?i)java|jdk")) | {message: .commit.message, date: .commit.author.date}'

Length of output: 15343

- sambamba >=1.0.1

test:
Expand Down
Loading