Use openjdk <=21 for hmftools-redux #52122
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/hmftools-redux/meta.yaml(1 hunks)
🔇 Additional comments (1)
recipes/hmftools-redux/meta.yaml (1)
15-15: LGTM: Build number increment is appropriate
The build number increment follows best practices for package updates without version changes.
| run_exports: | ||
| - {{ pin_subpackage('hmftools-redux', max_pin="x.x") }} | ||
|
|
||
| requirements: | ||
| run: | ||
| - openjdk >=8 | ||
| - openjdk >=8,<=21 |
There was a problem hiding this comment.
💡 Codebase verification
Java version constraint needs adjustment
Based on the upstream source code and recent commits, the Java version constraint should be adjusted. The upstream project explicitly sets Java 11 as the target version in its parent pom.xml (<java.version>11</java.version>), and there's a recent commit "INFRA-541 Redux: Use openjdk 11" specifically for this tool.
- The current constraint
>=8,<=21should be changed to>=11,<=21to align with the upstream requirements.
🔗 Analysis chain
Verify Java version compatibility with upstream
The addition of the upper bound <=21 for OpenJDK is a good practice to prevent potential compatibility issues with future Java versions. However, let's verify this constraint against upstream requirements.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify Java version compatibility with upstream project
# Check if there are any Java version requirements mentioned in the upstream repository
gh api repos/hartwigmedical/hmftools/contents/redux/README.md 2>/dev/null | jq -r '.content' | base64 -d | grep -i "java" || true
gh api repos/hartwigmedical/hmftools/contents/redux/pom.xml 2>/dev/null | jq -r '.content' | base64 -d | grep -i "<java.version>" || true
# Check for any Java version related issues or discussions
gh api search/issues -X GET -f q="repo:hartwigmedical/hmftools java version redux" | jq '.items[] | select(.title | test("(?i)java|jdk")) | {title: .title, url: .html_url}'
Length of output: 562
Script:
#!/bin/bash
# Let's try a different approach using direct GitHub API calls and processing the response differently
# Check pom.xml for Java version
gh api repos/hartwigmedical/hmftools/contents/redux/pom.xml | jq -r '.download_url' | xargs curl -s | grep -i "<java.version>"
# Check README.md for Java requirements
gh api repos/hartwigmedical/hmftools/contents/redux/README.md | jq -r '.download_url' | xargs curl -s | grep -i "java"
# Check for maven compiler plugin configuration which often specifies Java version
gh api repos/hartwigmedical/hmftools/contents/redux/pom.xml | jq -r '.download_url' | xargs curl -s | grep -A 5 -B 5 "maven-compiler-plugin"
Length of output: 835
Script:
#!/bin/bash
# Let's check the parent pom.xml for Java version properties
gh api repos/hartwigmedical/hmftools/contents/pom.xml | jq -r '.download_url' | xargs curl -s | grep -A 2 -B 2 "maven.compiler\|java.version"
# Also check if there are any recent commits mentioning Java version changes
gh api repos/hartwigmedical/hmftools/commits --paginate | jq -r '.[] | select(.commit.message | test("(?i)java|jdk")) | {message: .commit.message, date: .commit.author.date}'
Length of output: 15343
|
@BiocondaBot please fetch artifacts |
|
Package(s) built are ready for inspection:
|
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.