Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TRTools to 6.1.0 #51982

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Update TRTools to 6.1.0 #51982

merged 3 commits into from
Nov 7, 2024

Conversation

aryarm
Copy link
Contributor

@aryarm aryarm commented Nov 6, 2024

Closes #51983

Update trtools: 6.0.2 → 6.1.0

Please merge this PR instead of #51983. We've updated a dependency, added a dependency, and added an entrypoint.

Copy link
Contributor

coderabbitai bot commented Nov 6, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request introduces several changes to the meta.yaml file for the trtools package. The version of the package has been updated from 6.0.2 to 6.1.0, and the SHA256 checksum for the source tarball has been modified to match this new version. A new entry point named annotaTR has been added, which links to trtools.annotaTR:run.

Modifications in the requirements section include a downgrade of the minimum version constraint for the cyvcf2 dependency from >=0.30.4 to >=0.30.27, and the introduction of a new dependency, pgenlib, with a minimum version requirement of >=0.90.1.

In the test section, the imports list has been updated to include trtools.annotaTR, and the commands list now includes annotaTR --help, indicating that tests for the new functionality have been incorporated. Overall, the changes encompass version updates, new entry points, and adjustments to dependencies.

Suggested labels

autobump, new version


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 094474b and a01f63a.

📒 Files selected for processing (1)
  • recipes/trtools/meta.yaml (7 hunks)
🔇 Additional comments (5)
recipes/trtools/meta.yaml (5)

23-23: LGTM: New entry point follows existing pattern.

The new annotaTR entry point is properly configured and follows the same pattern as other existing entry points in the package.


36-36: Verify the cyvcf2 version downgrade.

The version constraint for cyvcf2 has been relaxed from >=0.30.4 to >=0.30.27. Please confirm:

  1. Is this downgrade intentional?
  2. Have you verified compatibility with older versions?
  3. Are there any known issues in versions between 0.30.27 and 0.30.4?

The new dependency pgenlib >=0.90.1 looks good.

Also applies to: 46-46


59-59: LGTM: Test coverage added for new functionality.

Appropriate test coverage has been added for the new annotaTR functionality, including both import and command-line tests.

Also applies to: 75-75


2-2: Verify SHA256 checksum of the source tarball.

Let's ensure the SHA256 checksum matches the source tarball from PyPI.

Also applies to: 10-10


93-95: Verify ARM platform compatibility.

The package is marked as noarch: python, but you've explicitly added ARM platforms. Please verify:

  1. Are there any platform-specific dependencies that require special handling on ARM?
  2. Have the dependencies been tested on ARM platforms?
#!/bin/bash
# Description: Check if dependencies have ARM platform support
# Look for platform-specific dependencies in requirements section

echo "Checking for platform-specific dependencies..."
rg "(?i)(arm|aarch64|platform|arch)" -A 5 -B 5

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aryarm aryarm mentioned this pull request Nov 7, 2024
@aryarm
Copy link
Contributor Author

aryarm commented Nov 7, 2024

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Nov 7, 2024
@aryarm
Copy link
Contributor Author

aryarm commented Nov 7, 2024

Thanks for the review!

@BiocondaBot please merge

I don't think I have permission to merge myself, unfortunately

@druvus druvus merged commit d06300a into bioconda:master Nov 7, 2024
6 checks passed
@aryarm aryarm deleted the bump/trtools branch November 7, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants