Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LotuS2: Fix usearch path in lOTUs.cfg #51870

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

nsoranzo
Copy link
Contributor

@nsoranzo nsoranzo commented Nov 1, 2024

No description provided.

Copy link
Contributor

coderabbitai bot commented Nov 1, 2024

📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request includes modifications to the build.sh script and the meta.yaml file for the LotuS2 project. In build.sh, the configs/sdm_src/ directory has been removed, along with files matching the pattern bin/lambda3*, indicating a cleanup of the binary directory. The script has been updated to include usearch as an additional binary in the configuration of the lOTUs.cfg file, while the structure of the sed command remains unchanged. The second loop for processing additional binaries continues to function as before, and installation steps related to the share directory and symbolic link for the LotuS2 wrapper have not been altered. In the meta.yaml file, the build.number has been incremented from 0 to 1, marking a new build iteration, with no other changes made to the package details or dependencies.

Possibly related PRs

  • Add FMSI #51277: Changes in the build.sh script for the FMSI package enhance the build process, similar to the modifications in the LotuS2 build.sh.
  • Update Earl Grey build.sh #51324: The update to the build.sh script in the Earl Grey package includes modifications for improved compatibility and functionality, aligning with the LotuS2 changes.
  • Update diamond recipe #51515: The build.sh script for the diamond package has undergone significant restructuring, which parallels the enhancements made in the LotuS2 build.sh, particularly in terms of improving the organization and clarity of the build process.
  • bump sainsc build number #51768: The increment of the build number in the meta.yaml file for the Sainsc package reflects a similar change made in the LotuS2 meta.yaml.

Suggested labels

please review & merge

Suggested reviewers

  • mencian

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bgruening bgruening merged commit a959d05 into bioconda:master Nov 2, 2024
6 checks passed
@nsoranzo nsoranzo deleted the lotus2_usearch branch November 3, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants