Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[biobb_amber] update 5.0.2 #51649

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[biobb_amber] update 5.0.2 #51649

merged 1 commit into from
Oct 25, 2024

Conversation

PauAndrio
Copy link
Contributor

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@PauAndrio PauAndrio enabled auto-merge (squash) October 25, 2024 08:54
Copy link
Contributor

coderabbitai bot commented Oct 25, 2024

📝 Walkthrough

Walkthrough

The pull request introduces updates to the meta.yaml file for the biobb_amber package. The version number is incremented from 5.0.0 to 5.0.2, and the SHA256 checksum for the source tarball is updated to align with the new version. The Python version constraints in the requirements section have been modified, changing from >=3.8,<3.11 to >=3.9,<3.11 for both host and run requirements. The dependencies on biobb_common and ambertools remain unchanged at ==5.0.0 and ==22.5.0, respectively. No alterations were made to the build or test sections, and the about section remains unchanged, maintaining the package's metadata integrity.

Possibly related PRs

  • [biobb_amber] update 5.0.0 #51430: The changes in this PR involve updating the meta.yaml file for the biobb_amber package, including version increments and Python version constraints, which are directly related to the updates made in the main PR for the biobb_amber package.
  • [biobb_analysis] update 5.0.0 #51431: This PR updates the biobb_analysis package's meta.yaml, including similar version and Python requirement changes, indicating a related update to the biobb_common dependency.
  • [biobb_chemistry] update 5.0.0 #51435: The biobb_chemistry package's meta.yaml is updated in this PR with changes to the version and Python requirements, which align with the modifications in the main PR regarding dependency updates.
  • [biobb_dna] update 5.0.0 #51601: This PR updates the biobb_dna package's meta.yaml, reflecting similar changes in versioning and Python requirements, indicating a connection to the main PR's updates.

Suggested labels

autobump, new version

Suggested reviewers

  • adamhospital
  • gbayarri

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ea2d6d1 and eb9bedd.

📒 Files selected for processing (1)
  • recipes/biobb_amber/meta.yaml (2 hunks)
🔇 Additional comments (4)
recipes/biobb_amber/meta.yaml (4)

Line range hint 12-18: Build configuration follows best practices

The build configuration is well-structured:

  • Correct build number reset to 0 for new version
  • Appropriate use of run_exports with pin_subpackage ensures ABI compatibility
🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


21-21: Breaking change: Dropping Python 3.8 support

The Python version constraint has been tightened from >=3.8,<3.11 to >=3.9,<3.11. This is a breaking change that could affect users still on Python 3.8. Please verify if this change is necessary and document the reason in the PR description.

#!/bin/bash
# Description: Check if dependencies require Python >=3.9
# Look for Python version requirements in biobb_common and other dependencies

echo "Checking biobb_common Python requirements..."
rg -A 5 "python" "recipes/biobb_common/meta.yaml"

echo "Checking if other biobb packages have similar Python constraints..."
fd "meta.yaml" "recipes" --exec rg -l "python.*>=3.9"

Also applies to: 26-26


23-24: Verify dependency versions compatibility

The fixed version pins look good:

  • biobb_common ==5.0.0 matches the major version
  • ambertools ==22.5.0 is maintained
#!/bin/bash
# Description: Verify dependency versions exist
# Check if specified versions of dependencies are available in bioconda

echo "Checking biobb_common availability..."
rg "version = \"5.0.0\"" "recipes/biobb_common/meta.yaml"

echo "Checking ambertools availability..."
rg "version = \"22.5.0\"" "recipes/ambertools/meta.yaml"

Also applies to: 27-28


2-2: Verify SHA256 checksum against PyPI source

The version bump from 5.0.0 to 5.0.2 looks good as it's a minor update. Let's verify the SHA256 checksum matches the PyPI source.

Also applies to: 10-10

✅ Verification successful

Let me try a different approach to verify the SHA256 checksum since the previous script had some issues.


SHA256 checksum verification successful

The SHA256 checksum (33cd128cd6b8efb66b83876f978f85447c49e35a98b95bd11e0c74960c76af50) in the meta.yaml matches exactly with the official PyPI source for biobb_amber 5.0.2.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify SHA256 checksum matches PyPI source
# Download the package from PyPI and compute its checksum
VERSION="5.0.2"
PACKAGE="biobb_amber"
EXPECTED_SHA="33cd128cd6b8efb66b83876f978f85447c49e35a98b95bd11e0c74960c76af50"

# Create temp directory
TEMP_DIR=$(mktemp -d)
cd "$TEMP_DIR"

# Download package and compute SHA256
curl -sL "https://pypi.io/packages/source/b/${PACKAGE}/${PACKAGE}-${VERSION}.tar.gz" | sha256sum | cut -d' ' -f1 | tr -d '\n' > sha256.txt

# Compare with expected SHA256
if [ "$(cat sha256.txt)" = "$EXPECTED_SHA" ]; then
    echo "SHA256 checksum verified successfully"
else
    echo "SHA256 mismatch!"
    echo "Expected: $EXPECTED_SHA"
    echo "Got: $(cat sha256.txt)"
fi

Length of output: 752


Script:

#!/bin/bash
# Get the SHA256 from meta.yaml
echo "Extracting SHA256 from meta.yaml..."
rg "sha256:" recipes/biobb_amber/meta.yaml

# Check if package exists on PyPI
echo "Checking package on PyPI..."
curl -s "https://pypi.org/pypi/biobb_amber/5.0.2/json" | jq -r '.urls[] | select(.packagetype=="sdist") | .digests.sha256'

Length of output: 451


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants