Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: deepchopper #51460

Merged
merged 30 commits into from
Oct 29, 2024
Merged

Add: deepchopper #51460

merged 30 commits into from
Oct 29, 2024

Conversation

cauliyang
Copy link
Contributor

Describe your pull request here

Language models identify chimeric artificial reads in NanoPore direct-RNA sequencing data.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@cauliyang
Copy link
Contributor Author

@mencian, Thanks for cleaning the code, and have a good one!

- setuptools
run:
- python
- torch >=2.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ARM64 builds fail due to:

11:23:33 BIOCONDA INFO (OUT) Encountered problems while solving:
11:23:33 BIOCONDA INFO (OUT)   - nothing provides requested torch >=2.1.0

But https://anaconda.org/search?q=torch does not list such package in conda-forge and/or bioconda channels at all.
I guess the same error will be reported for x86_64 once the CI issue is solved.
Did you mean https://anaconda.org/conda-forge/pytorch ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martin-g, thank you for your excellent help! I just realize I made a mistake. The PyTorch package names are different for conda and pip:
In conda: 'pytorch'
In pip: 'torch'"

I've found two good PyTorch options:

The conda-forge version (conda-forge/pytorch) which works great for my needs
The official PyTorch channel (pytorch/pytorch) which provides the latest releases

Both are available through Anaconda, and I can work with either option.
Again, Thanks for your help!

@mencian mencian marked this pull request as ready for review October 29, 2024 02:46
@mencian mencian merged commit 24d1739 into bioconda:master Oct 29, 2024
5 of 6 checks passed
Copy link
Contributor

coderabbitai bot commented Oct 29, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request introduces two key components for the "deepchopper" package: a new build.sh script and a meta.yaml file. The build.sh script is designed to automate the setup and build process for a Rust project that integrates with Python. It includes error handling, installs Rust, modifies the PATH, compiles the project using maturin, and installs the generated wheel files using pip. The script also contains a commented-out section for macOS compatibility.

The meta.yaml file provides detailed metadata about the "deepchopper" package, including its name, version, SHA256 checksum, source URL, build conditions, entry points, dependencies, and testing requirements. It specifies that the package is compatible with Python versions 3.10 and above and includes a variety of dependencies necessary for its functionality. Additionally, it outlines the package's purpose related to genomic language modeling for RNA sequencing and lists supported platforms and maintainers.

Possibly related PRs

  • add pantax #50983: The build.sh script in this PR also automates the installation process for a software package, similar to the new build.sh script in the main PR.
  • Add recipe for rukki v0.3.0 #51115: This PR introduces a build.sh script that builds a Rust package, aligning with the Rust integration focus of the main PR's build.sh.
  • add gfainject #51287: The build.sh script here is designed for a Rust package, suggesting a commonality in the use of Rust for building packages.
  • Add seqspec #51326: The meta.yaml file in this PR outlines package configurations, including dependencies, similar to the meta.yaml changes in the main PR.
  • add meta #51349: The introduction of a new build.sh script and meta.yaml for the "meta" package indicates a focus on building and installation processes, akin to the changes in the main PR.
  • add recipe for steamboat #51612: The meta.yaml and build.sh in this PR also focus on package installation and configuration, paralleling the objectives of the main PR.
  • add ampd-up v1.0.0 #51688: The build.sh script for the "ampd-up" package focuses on installation processes, similar to the automation goals of the main PR's build.sh.

Suggested labels

please review & merge


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cauliyang
Copy link
Contributor Author

@mencian, appreciate your big help again! Have a good one.

@mencian
Copy link
Contributor

mencian commented Oct 29, 2024

Anytime~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants