Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin gsl to 2.5 for rmats #51411

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Pin gsl to 2.5 for rmats #51411

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6cbfe7
Pin gsl to 2.5 for rmats
npavlovikj Oct 15, 2024
2d7c26e
Fix pinning
npavlovikj Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions recipes/rmats/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ source:
url: https://github.com/Xinglab/rmats-turbo/releases/download/v{{ version }}/rmats_turbo_v{{ version|replace(".","_") }}.tar.gz

build:
number: 2
number: 3
run_exports:
- {{ pin_subpackage(name, max_pin="x") }}

Expand All @@ -26,14 +26,14 @@ requirements:
- python
- cython
- numpy
- gsl
- gsl=2.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider adding a run_exports section for GSL.

While pinning GSL to version 2.5 is correct, the PR objectives mention adding a run_exports section to prevent potential API, ABI, or CLI breakage issues. Consider adding this section to the gsl package in its recipe, not in the rmats recipe.

Here's an example of how it might look in the gsl package recipe:

build:
  run_exports:
    - {{ pin_subpackage('gsl', max_pin='x.x') }}

This ensures that packages depending on GSL will automatically use the correct version constraints.

- zlib
- libblas
- liblapack
run:
- python
- numpy
- gsl
- gsl=2.5
- zlib
- star >=2.5

Expand All @@ -50,4 +50,4 @@ about:

extra:
additional-platforms:
- linux-aarch64
- linux-aarch64
Loading