Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloudspades #51399

Merged
merged 26 commits into from
Oct 17, 2024
Merged
Changes from 14 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6da07a5
add cloudspades
pdimens Oct 15, 2024
9c352db
Rename recipes/spades/cloudspades/meta.yaml to recipes/cloudspades/me…
pdimens Oct 15, 2024
a75105d
rm flags, better versioning, rm arm
pdimens Oct 15, 2024
3fd1c6b
Merge branch 'master' into cloudspades
pdimens Oct 15, 2024
0745483
rm aarch
pdimens Oct 15, 2024
ac115e9
fix build
pdimens Oct 15, 2024
8e74a52
add ignore exports, link to the license file directly
pdimens Oct 15, 2024
b548ac9
fix constraint
pdimens Oct 15, 2024
2045d43
fix license path
pdimens Oct 15, 2024
e8c704e
simplify tests b/c cloudspades acts different
pdimens Oct 15, 2024
ad59ff4
Merge branch 'master' into cloudspades
pdimens Oct 15, 2024
3d88e6f
skip osk. make life easier
pdimens Oct 15, 2024
57b00e9
add proper test
pdimens Oct 15, 2024
4f2d95b
add gz
pdimens Oct 15, 2024
6692969
try building with less threads
mencian Oct 16, 2024
9260860
fix tests
mencian Oct 16, 2024
0399e25
edit test command
mencian Oct 16, 2024
a373b6b
do not build on aarch64/arm64
mencian Oct 16, 2024
817a88b
Merge branch 'master' into cloudspades
mencian Oct 16, 2024
af16fd4
add case for Darwin
mencian Oct 16, 2024
871a400
Merge branch 'master' into cloudspades
mencian Oct 16, 2024
140ff1c
Merge branch 'master' into cloudspades
mencian Oct 16, 2024
f1a7429
edit case
mencian Oct 16, 2024
a443735
Merge branch 'master' into cloudspades
mencian Oct 16, 2024
73936dd
Add "-D_LIBCPP_DISABLE_AVAILABILITY" for OSX
martin-g Oct 16, 2024
083460a
skip osx x86_64 for now
mencian Oct 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions recipes/cloudspades/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
{% set name = "cloudspades" %}
{% set version = "3.16.0" %}
{% set sha256 = "5972a76722fadf9527675fea3884a03ca864b153b8de9dd94532b1b797de04aa" %}

package:
name: {{ name }}
version: {{ version }}

source:
url: https://github.com/ablab/spades/archive/refs/tags/cloudspades-0.1.tar.gz
sha256: {{ sha256 }}
pdimens marked this conversation as resolved.
Show resolved Hide resolved


build:
number: 0
skip: True # [osx]

run_exports:
- {{ pin_subpackage('cloudspades', max_pin="x") }}
ignore_run_exports:
- libgomp
- zlib
- bzip2
script: |
export LIBRARY_PATH="${PREFIX}/lib"
export INCLUDE_PATH="${PREFIX}/include"
export CFLAGS="${CFLAGS} -O3"
export CXXFLAGS="${CFLAGS} -O3 -I${PREFIX}/include"
PREFIX="${PREFIX}" cd assembler && bash spades_compile.sh -DSPADES_ENABLE_PROJECTS="all"


requirements:
build:
- {{ compiler('cxx') }}
- cmake
- make
- pkg-config
host:
- libgomp # [linux]
- zlib
- bzip2
run:
- libgomp # [linux]
- python >=3.8

test:
commands:
- spades.py --version 2>&1 | grep {{ version }}
- metaspades.py --version 2>&1 | grep {{ version }}
- spades-kmercount -h 2>&1 | grep spades-kmercount
- spades-gmapper 2>&1 | grep spades-gmapper
- spades-gbuilder 2>&1 | grep spades-gbuilder
- spades.py --gemcode1-12 assembler/test_dataset_cloudspades/test.fastq.gz -o cloudspades_test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Update version checks in test commands

The test commands use {{ version }} for version checks, which currently refers to version 3.16.0. This may cause the tests to fail due to the version mismatch with the source URL (cloudspades-0.1) identified earlier.

After resolving the version mismatch issue, ensure that the version checks in the test commands are updated accordingly. For example:

  commands:
    - spades.py --version 2>&1 | grep {{ version }}
    - metaspades.py --version 2>&1 | grep {{ version }}

Replace {{ version }} with the correct version once it's been determined and consistently applied throughout the recipe.


about:
home: "https://github.com/ablab/spades"
license: "GPL-2.0-only"
license_family: GPL
license_file: 'assembler/LICENSE'
summary: "A module of the SPAdes assembler aimed at genome assembly from linked read technologies (10x, Tellseq, Haplotagging)."
dev_url: "https://github.com/ablab/spades"
doc_url: "https://github.com/ablab/spades/tree/cloudspades-ismb"

extra:
recipe-maintainers:
- pdimens