-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloudspades #51399
Add Cloudspades #51399
Changes from all commits
6da07a5
9c352db
a75105d
3fd1c6b
0745483
ac115e9
8e74a52
b548ac9
2045d43
e8c704e
ad59ff4
3d88e6f
57b00e9
4f2d95b
6692969
9260860
0399e25
a373b6b
817a88b
af16fd4
871a400
140ff1c
f1a7429
a443735
73936dd
083460a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
diff -Naur a/assembler/spades_compile.sh b/assembler/spades_compile.sh | ||
--- a/assembler/spades_compile.sh 2024-05-26 14:36:40 | ||
+++ b/assembler/spades_compile.sh 2024-05-27 13:00:03 | ||
@@ -37,10 +37,10 @@ check_whether_OPTARG_is_an_integer() { | ||
} | ||
|
||
# return the argument first character | ||
-str_head() { echo "$(expr substr "$1" 1 1)"; } | ||
+str_head() { echo "${1::1}"; } | ||
|
||
# return the argument without the first character | ||
-str_tail() { echo "$(expr substr "$1" 2 $((${#1}-1)))"; } | ||
+str_tail() { echo "${1:1}"; } | ||
|
||
print_help() { | ||
echo | ||
@@ -221,11 +221,21 @@ else | ||
ADDITIONAL_FLAGS="$ADDITIONAL_FLAGS -DSPADES_BUILD_INTERNAL=OFF" | ||
fi | ||
|
||
-cd "$WORK_DIR" | ||
-cmake -G "Unix Makefiles" -DCMAKE_INSTALL_PREFIX="$PREFIX" $ADDITIONAL_FLAGS "$BASEDIR/src" | ||
-make -j $AMOUNT_OF_THREADS | ||
-make install | ||
-cd "$PREFIX" | ||
+if [[ `uname` == "Darwin" ]]; then | ||
+ export CONFIG_ARGS="-DCMAKE_FIND_FRAMEWORK=NEVER -DCMAKE_FIND_APPBUNDLE=NEVER" | ||
+ export CFLAGS="${CFLAGS} -Wunused-command-line-argument" | ||
+ export CXXFLAGS="${CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY" | ||
+else | ||
+ export CONFIG_ARGS="" | ||
+fi | ||
+ | ||
+cd "${WORK_DIR}" | ||
+cmake -S "${BASEDIR}/src" -B . -G "Unix Makefiles" -DCMAKE_INSTALL_PREFIX="${PREFIX}" \ | ||
+ -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_COMPILER="${CXX}" \ | ||
+ -DCMAKE_CXX_FLAGS="${CXXFLAGS}" -DCMAKE_C_COMPILER="${CC}" \ | ||
+ -DCMAKE_C_FLAGS="${CFLAGS}" "${ADDITIONAL_FLAGS}" \ | ||
+ "${CONFIG_ARGS}" | ||
+cmake --build . --target install -j "${AMOUNT_OF_THREADS}" -v | ||
|
||
if [ $RUN_TESTS = "y" ]; then | ||
cd "$BASEDIR" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
#!/bin/bash | ||
|
||
set -e -o pipefail -x | ||
|
||
export LIBRARY_PATH="${PREFIX}/lib" | ||
export INCLUDE_PATH="${PREFIX}/include" | ||
export CFLAGS="${CFLAGS} -O3 -fcommon" | ||
export CXXFLAGS="${CFLAGS} -O3 -fcommon -I${PREFIX}/include -D_LIBCPP_DISABLE_AVAILABILITY" | ||
|
||
case $(uname) in | ||
Linux) | ||
THREADS="-rj${CPU_COUNT}" | ||
;; | ||
Darwin) | ||
THREADS="" | ||
;; | ||
esac | ||
|
||
cd assembler | ||
PREFIX="${PREFIX}" bash spades_compile.sh "${THREADS}" -DSPADES_ENABLE_PROJECTS="all" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
{% set name = "cloudspades" %} | ||
{% set version = "3.16.0" %} | ||
{% set sha256 = "5972a76722fadf9527675fea3884a03ca864b153b8de9dd94532b1b797de04aa" %} | ||
|
||
package: | ||
name: {{ name }} | ||
version: {{ version }} | ||
|
||
source: | ||
url: https://github.com/ablab/spades/archive/refs/tags/cloudspades-0.1.tar.gz | ||
sha256: {{ sha256 }} | ||
pdimens marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
build: | ||
number: 0 | ||
skip: True # [osx] | ||
run_exports: | ||
- {{ pin_subpackage('cloudspades', max_pin="x") }} | ||
|
||
requirements: | ||
build: | ||
- {{ compiler('cxx') }} | ||
- cmake | ||
- make | ||
- pkg-config | ||
host: | ||
- libgomp # [linux] | ||
- llvm-openmp # [osx] | ||
- zlib | ||
- bzip2 | ||
run: | ||
- libgomp # [linux] | ||
- llvm-openmp # [osx] | ||
- python >=3.8 | ||
|
||
test: | ||
commands: | ||
- spades.py --version 2>&1 | grep {{ version }} | ||
- metaspades.py --version 2>&1 | grep {{ version }} | ||
- spades-kmercount -h 2>&1 | grep spades-kmercount | ||
- spades-gmapper 2>&1 | grep spades-gmapper | ||
- spades-gbuilder 2>&1 | grep spades-gbuilder | ||
|
||
pdimens marked this conversation as resolved.
Show resolved
Hide resolved
|
||
about: | ||
home: "https://github.com/ablab/spades" | ||
license: "GPL-2.0-only" | ||
license_family: GPL | ||
license_file: 'assembler/LICENSE' | ||
summary: "A module of the SPAdes assembler aimed at genome assembly from linked read technologies (10x, Tellseq, Haplotagging)." | ||
dev_url: "https://github.com/ablab/spades/tree/cloudspades-0.1" | ||
doc_url: "https://github.com/ablab/spades/tree/cloudspades-ismb" | ||
pdimens marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
extra: | ||
recipe-maintainers: | ||
- pdimens | ||
Comment on lines
+1
to
+54
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Overall assessment: Well-structured recipe with critical issues to address The Cloudspades recipe is generally well-written and follows Conda packaging best practices. It includes comprehensive metadata, appropriate build instructions, well-defined requirements, and thorough test commands. However, there are critical issues that need to be addressed before the recipe can be included in the Bioconda repository:
Once these issues are addressed, the recipe should be ready for inclusion in the Bioconda repository. Please review and update the highlighted sections to ensure consistency and correctness throughout the recipe. Would you like assistance in resolving these issues or implementing the suggested improvements? 🧰 Tools🪛 yamllint
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix incorrect parameter expansion syntax in
str_head
functionThe new implementation of
str_head()
uses${1::1}
to extract the first character, but this syntax is invalid in bash. The correct syntax should be${1:0:1}
.Apply this diff to fix the syntax error:
📝 Committable suggestion