Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to fix a vcf output error #51319

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

mchaisso
Copy link
Contributor

This updates vamos to v2.1.5. v2.1.4 had an error in the vcf output format.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Copy link
Contributor

coderabbitai bot commented Oct 10, 2024

📝 Walkthrough

Walkthrough

The pull request introduces an update to the meta.yaml file for the vamos package. The version number has been incremented from "2.1.4" to "2.1.5". Alongside this version change, the source URL has been updated to reflect the new version's tarball, linking to vamos-v2.1.5.tar.gz instead of the previous vamos-v2.1.4.tar.gz. Additionally, the SHA256 checksum associated with the source tarball has been modified to a new value, indicating that the contents of the package have changed. The remainder of the meta.yaml file, including package name, build requirements, host requirements, run requirements, test commands, and other metadata, remains unchanged.

Possibly related PRs

  • 2024.4 #50977: This PR updates the meta.yaml file for the biobb_structure_checking package, changing the version and SHA256 checksum, similar to the version and checksum updates in the main PR for the vamos package.
  • Update Hsdecipher #51093: This PR updates the meta.yaml file for the HSDecipher package, changing the version and SHA256 checksum, which parallels the changes made in the main PR for the vamos package.

Suggested labels

please review & merge


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8c12e52 and 286498a.

📒 Files selected for processing (1)
  • recipes/vamos/meta.yaml (2 hunks)
🧰 Additional context used
🪛 yamllint
recipes/vamos/meta.yaml

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)

🔇 Additional comments (4)
recipes/vamos/meta.yaml (4)

1-1: Version update looks good.

The version has been correctly updated to 2.1.5, which aligns with the PR objective to upgrade vamos.

🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


9-9: Source URL update is correct.

The source URL has been properly updated to reflect the new version 2.1.5, maintaining the correct format for GitHub releases.


Line range hint 1-50: Overall, the meta.yaml file looks good with appropriate updates.

The changes to version, source URL, and SHA256 checksum are consistent and correctly implemented. The rest of the file, including build settings, requirements, and metadata, remains unchanged and follows Bioconda guidelines.

Some notable points:

  1. The run_exports directive in the build section is a good practice for ensuring compatibility with downstream recipes.
  2. The specific version pins for zlib (1.2.*) are consistently applied across different sections, which helps maintain compatibility.

Regarding the static analysis hint:

The yamllint error about a syntax error with the '%' character is a false positive. The use of Jinja2 templating ({% ... %}) is standard and correct in Bioconda meta.yaml files. No action is needed to address this hint.


10-10: SHA256 checksum has been updated.

The SHA256 checksum has been changed to reflect the new version of the package. This is expected and consistent with the version update.

To ensure the integrity of the package, please verify that this checksum is correct for the new version. You can use the following script to download the package and verify the checksum:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bgruening bgruening merged commit 7f3f282 into bioconda:master Oct 11, 2024
7 checks passed
@bgruening
Copy link
Member

Thanks!

@coderabbitai coderabbitai bot mentioned this pull request Oct 16, 2024
@coderabbitai coderabbitai bot mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants