Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kmc: add arm64 build #51281

Merged
merged 1 commit into from
Oct 9, 2024
Merged

kmc: add arm64 build #51281

merged 1 commit into from
Oct 9, 2024

Conversation

mencian
Copy link
Contributor

@mencian mencian commented Oct 9, 2024

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@mencian mencian added the osx-arm64 Related to adding osx-arm64 support label Oct 9, 2024
Copy link
Contributor

coderabbitai bot commented Oct 9, 2024

📝 Walkthrough

Walkthrough

The pull request introduces modifications to two files: build.sh and meta.yaml within the KMC package. In build.sh, the conditional syntax for checking the operating system has been updated from a single bracket [ to a double bracket [[, enhancing the robustness of the script while maintaining the same logic for file operations. In meta.yaml, several significant changes are made, including the addition of a new URL and SHA256 hash for the macOS ARM64 architecture, and updates to the existing macOS x64 URL and SHA256 hash to include architecture specifications in the comments. The build number is incremented from 1 to 2, and the run dependencies for zlib and bzip2 have been removed. The license declaration has been updated to "GPL-3.0-or-later," and the license file reference has been reformatted. Additionally, support for the osx-arm64 platform has been added under the extra platforms section. These changes reflect updates in platform support, dependency management, and minor formatting adjustments.

Possibly related PRs

Suggested labels

please review & merge, aarch64


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6942d4d and e76ff73.

📒 Files selected for processing (2)
  • recipes/kmc/build.sh (1 hunks)
  • recipes/kmc/meta.yaml (3 hunks)
✅ Files skipped from review due to trivial changes (1)
  • recipes/kmc/build.sh
🧰 Additional context used
🔇 Additional comments (6)
recipes/kmc/meta.yaml (6)

7-10: LGTM: Added support for macOS ARM64 architecture

The changes correctly add support for the macOS ARM64 architecture while maintaining the existing macOS x86_64 support. The URLs and SHA256 hashes are consistent with the package version.


21-21: LGTM: Build number incremented

The build number has been correctly incremented from 1 to 2. This follows best practices for Conda packaging when making changes to the package without changing the upstream version.


35-35: LGTM: Minor formatting improvement

The formatting change in the test command improves consistency without affecting functionality.


43-43: LGTM: Improved license declaration

The license declaration has been updated to "GPL-3.0-or-later", providing more precise information about the applicable license versions. The license file reference is now enclosed in quotes, improving consistency and preventing potential parsing issues. These changes align with best practices for license declarations in Conda recipes.

Also applies to: 45-45


51-51: LGTM: Added osx-arm64 to additional platforms

The addition of "osx-arm64" to the list of additional platforms is consistent with the earlier changes to support macOS ARM64. This ensures that the package can be built for the macOS ARM64 platform, improving compatibility across different architectures.


Line range hint 24-30: Please clarify the removal of run dependencies

The run dependencies for zlib and bzip2 have been removed from the requirements section. Could you please explain the rationale behind this change? Removing these dependencies might potentially cause issues for users of the package if the KMC binaries still require these libraries at runtime.

To confirm if these libraries are still required at runtime, we can check the binary dependencies:

If the script output shows that these libraries are still required, we should consider keeping them as run dependencies.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mencian mencian merged commit 9b4107e into master Oct 9, 2024
7 checks passed
@mencian mencian deleted the kmc branch October 9, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
osx-arm64 Related to adding osx-arm64 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant