Update Harpy deps #51278
Update Harpy deps #51278
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies the Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/harpy/meta.yaml (1)
38-38: LGTM: Addition of conda dependency is appropriate.The addition of conda as a dependency with version >24.7 aligns with the PR objective. This ensures that harpy will work with recent conda features.
Consider updating the package documentation to mention this new conda version requirement, if not already done.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/harpy/meta.yaml (2 hunks)
🧰 Additional context used
🔇 Additional comments (4)
recipes/harpy/meta.yaml (4)
13-13: LGTM: Build number increment is appropriate.The build number has been correctly incremented from 0 to 1. This is the expected practice when updating package dependencies without changing the package version itself.
44-44: LGTM: samtools dependency update is consistent with other changes.The update of samtools from version 1.20 to 1.21 is consistent with the bcftools update and aligns with the PR objective of updating HTSlib to version 1.21.
To ensure compatibility, please run the following script to check if there are any version-specific calls to samtools in the harpy codebase:
#!/bin/bash # Description: Check for version-specific samtools calls in the harpy codebase # Test: Search for samtools calls with version-specific options rg --type python -i 'samtools.*1\.20'
37-37: LGTM: bcftools dependency update is in line with PR objectives.The update of bcftools from version 1.20 to 1.21 aligns with the PR objective of updating HTSlib to version 1.21. This change is appropriate and consistent.
To ensure compatibility, please run the following script to check if there are any version-specific calls to bcftools in the harpy codebase:
Line range hint
1-85: Summary: All changes look good and align with PR objectives.The updates to bcftools and samtools versions, the addition of the conda dependency, and the build number increment are all appropriate and consistent with the PR objectives. These changes should improve the package's compatibility with the latest tools.
As a final check, please ensure that:
- The package still builds and runs correctly with these updated dependencies.
- Any documentation or README files are updated to reflect the new dependency requirements, especially the new conda version requirement.
- The package's functionality is tested with these new dependency versions to ensure no regressions.
To verify the overall integrity of the package, please run the following script:
|
@BiocondaBot please add label |
|
LGTM, thanks @pdimens! |
This adds
condaas a bounded dependency and bumps the HTSlib versions to 1.21Otherwise, everything else is the same
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.