Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hmftools-amber to 4.1_beta #51141

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

scwatts
Copy link
Contributor

@scwatts scwatts commented Oct 4, 2024

Update hmftools-amber recipe to 4.1_beta


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Summary by CodeRabbit

  • New Features

    • Updated the hmftools-amber package to version 4.1_beta, enhancing functionality and performance.
    • Improved source URL structure for easier access to the latest releases.
  • Bug Fixes

    • Corrected SHA256 checksum to ensure integrity and security of the package.

Copy link
Contributor

coderabbitai bot commented Oct 4, 2024

📝 Walkthrough

Walkthrough

The pull request updates the meta.yaml file for the hmftools-amber package. It changes the version from "4.0.1" to "4.1_beta" and updates the SHA256 checksum accordingly. Additionally, the source URL is modified to accommodate the new versioning scheme, where "_beta" is replaced with an empty string in the URL. Other contents of the file, such as package metadata and requirements, remain unchanged.

Changes

File Change Summary
recipes/hmftools-amber/meta.yaml - Updated version from "4.0.1" to "4.1_beta".
- Updated sha256 from "ab4934e503d..." to "ceef94ee067...".
- Updated url to replace "_beta" in version for URL construction.

Possibly related PRs

  • 2024.4 #50977: Updates the meta.yaml file for the biobb_structure_checking package, changing the version and SHA256 checksum.
  • update Hsdecipher des #51023: Modifies the meta.yaml file for the hsdecipher package, updating the SHA256 checksum and version.
  • Update Hsdfinder script #51058: Updates the meta.yaml file for the hsdfinder package with a version increment and SHA256 checksum change.
  • Update Hsdfinder #51092: Changes the version and SHA256 checksum in the meta.yaml file for the hsdfinder package.
  • Update Hsdecipher #51093: Updates the meta.yaml file for the hsdecipher package, changing the version and SHA256 checksum.

Suggested labels

autobump, new version


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e9865fd and 8487a27.

📒 Files selected for processing (1)
  • recipes/hmftools-amber/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/hmftools-amber/meta.yaml

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)

🔇 Additional comments (2)
recipes/hmftools-amber/meta.yaml (2)

9-9: URL updated correctly for beta version

The source URL has been updated to handle the beta version correctly. The replace("_beta", "") filter ensures that the correct filename is used for downloading the JAR file.

Let's verify that the URL is correct and the file exists:

✅ Verification successful

URL updated correctly and verified

The updated source URL successfully points to an existing JAR file. The replace("_beta", "") filter correctly formats the URL, and the file amber_v4.1_beta.jar exists at the specified location.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence of the JAR file at the specified URL

# Extract the version and construct the URL
version="4.1_beta"
url="https://github.com/hartwigmedical/hmftools/releases/download/amber-v${version//_beta/}/amber_v${version}.jar"

# Test: Check if the URL is accessible
if curl --output /dev/null --silent --head --fail "$url"; then
    echo "URL is valid and file exists: $url"
else
    echo "Error: File not found or URL is invalid: $url"
fi

Length of output: 510


1-2: Verify stability of beta version

The version has been updated to "4.1_beta" and the SHA256 checksum has been updated accordingly. These changes are consistent with the PR objective.

Please ensure that this beta version is stable enough for inclusion in the Bioconda channel. Consider the following:

  1. Has this beta version been tested thoroughly?
  2. Are there any known issues that might affect users?
  3. Is there a plan for updating to the stable release when it becomes available?
✅ Verification successful

Beta Version Stability Verified

The beta version "4.1_beta" has been confirmed to be stable based on current checks:

  • The release URL is valid and the file exists.
  • No open issues or PRs related to the stability of "amber 4.1_beta" were found.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if there are any issues or discussions about the stability of this beta version.

# Test: Search for any mentions of stability issues or beta version discussions
gh issue list -R hartwigmedical/hmftools --search "in:title,body amber 4.1_beta"
gh pr list -R hartwigmedical/hmftools --search "in:title,body amber 4.1_beta"

Length of output: 510

🧰 Tools
🪛 yamllint

[error] 1-1: syntax error: found character '%' that cannot start any token

(syntax)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@scwatts
Copy link
Contributor Author

scwatts commented Oct 4, 2024

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
noarch hmftools-amber-4.1_beta-hdfd78af_0.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
hmftools-amber 4.1_beta--hdfd78af_0 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/hmftools-amber:4.1_beta--hdfd78af_0.tar.gz | docker load

@scwatts
Copy link
Contributor Author

scwatts commented Oct 4, 2024

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants