-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build raxml for osx-arm64 #49098
Build raxml for osx-arm64 #49098
Conversation
@martin-g I noticed you upstreamed some changes to raxml to add aarch64 support. Maybe you could do likewise here? I'm using a patch for now as I don't understand the details of the necessary changes, but would be cool if you could have a look at whether we might build with pthreads etc for arm64 as well. |
@BiocondaBot please add label |
@BiocondaBot please fetch artifacts |
Package(s) built are ready for inspection:
Docker image(s) built:
|
Ah this is a great point! I don't quite remember, maybe I was trying to
debug locally and didn't have the CC env variable set. I don't know very
much about make yet.
Thanks for your eyes!
…On Thu, Jul 11, 2024, 09:16 Martin Grigorov ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In recipes/raxml/build.sh
<#49098 (comment)>
:
> @@ -24,8 +33,8 @@ for PTHREADS in "" .PTHREADS; do
else
MAKEFILE=${MAKEFILE}.gcc
fi
- make -f ${MAKEFILE} CC=$CC
Why did you remove CC=$CC ?
I think this is the reason why now you need the patch (to remove CC = gcc.
—
Reply to this email directly, view it on GitHub
<#49098 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF77AQK6HEJDYVLU57QZ36LZLYWM3AVCNFSM6AAAAABKVUIQOGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZRGEYDINBSGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
* Build raxml for osx-arm64 * Disable failing arm64 builds * Apply patch to not overwrite CC env variable
No description provided.