add proper tests to intervene #25392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove/invert restriction on pandas which was fixed in 0.6.5 asntech/intervene#40 (comment) - running the tool outputs deprection warnings for matplotlib >= 3.4 .. so I added a version restriction
for
```
Traceback (most recent call last):
File "/home/circleci/project/miniconda/bin/bioconda-utils", line 8, in <module>
sys.exit(main())
File "/home/circleci/project/miniconda/lib/python3.7/site-packages/bioconda_utils/cli.py", line 971, in main
bioconductor_skeleton, clean_cran_skeleton, autobump, bot
File "/home/circleci/project/miniconda/lib/python3.7/site-packages/argh/dispatching.py", line 328, in dispatch_commands
dispatch(parser, *args, **kwargs)
File "/home/circleci/project/miniconda/lib/python3.7/site-packages/argh/dispatching.py", line 174, in dispatch
for line in lines:
File "/home/circleci/project/miniconda/lib/python3.7/site-packages/argh/dispatching.py", line 277, in _execute_command
for line in result:
File "/home/circleci/project/miniconda/lib/python3.7/site-packages/argh/dispatching.py", line 260, in _call
result = function(*positional, **keywords)
File "<boltons.funcutils.FunctionBuilder-5>", line 2, in build
File "/home/circleci/project/miniconda/lib/python3.7/site-packages/bioconda_utils/cli.py", line 130, in wrapper
func(*args, **kwargs)
File "<boltons.funcutils.FunctionBuilder-4>", line 2, in build
File "/home/circleci/project/miniconda/lib/python3.7/site-packages/bioconda_utils/cli.py", line 59, in wrapper
func(*args, **kwargs)
File "/home/circleci/project/miniconda/lib/python3.7/site-packages/bioconda_utils/cli.py", line 476, in build
keep_old_work=keep_old_work)
File "/home/circleci/project/miniconda/lib/python3.7/site-packages/bioconda_utils/build.py", line 343, in build_recipes
linter=linter)
File "/home/circleci/project/miniconda/lib/python3.7/site-packages/bioconda_utils/build.py", line 149, in build
pkg_test.test_package(pkg_path, base_image=base_image)
File "/home/circleci/project/miniconda/lib/python3.7/site-packages/bioconda_utils/pkg_test.py", line 170, in test_package
p = utils.run(cmd, env=env, cwd=d, mask=False)
File "/home/circleci/project/miniconda/lib/python3.7/tempfile.py", line 805, in __exit__
self.cleanup()
File "/home/circleci/project/miniconda/lib/python3.7/tempfile.py", line 809, in cleanup
_shutil.rmtree(self.name)
File "/home/circleci/project/miniconda/lib/python3.7/shutil.py", line 485, in rmtree
_rmtree_safe_fd(fd, path, onerror)
File "/home/circleci/project/miniconda/lib/python3.7/shutil.py", line 423, in _rmtree_safe_fd
_rmtree_safe_fd(dirfd, fullname, onerror)
File "/home/circleci/project/miniconda/lib/python3.7/shutil.py", line 443, in _rmtree_safe_fd
onerror(os.unlink, fullname, sys.exc_info())
File "/home/circleci/project/miniconda/lib/python3.7/shutil.py", line 441, in _rmtree_safe_fd
os.unlink(entry.name, dir_fd=topfd)
PermissionError: [Errno 13] Permission denied: 'Intervene_pairwise_frac_matrix.txt'
```
bernt-matthias
force-pushed
the
topic/intervene-tests-requirements
branch
from
094796c to
86a5e7c
Compare
|
@BiocondaBot please add label |
|
@BiocondaBot please merge |
|
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so I added a version restriction
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
For members of the Bioconda project, the following command is also available:
@BiocondaBot please mergeSomeone must approve a PR first!
This reduces CI build time by reusing built artifacts.
Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.