Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sha256sum for falco. Release was changed to be conda compatible #19284

Merged
merged 8 commits into from
Dec 14, 2019
Merged

update sha256sum for falco. Release was changed to be conda compatible #19284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
214b9a9
first attempt to add falco to bioconda
guilhermesena1 Dec 13, 2019
2bf5c65
second attempt based on first failure
guilhermesena1 Dec 13, 2019
79f190a
testing if 'run' solves the mac compile error
guilhermesena1 Dec 13, 2019
9a4e894
fourth test to see if htslib path is now found
guilhermesena1 Dec 13, 2019
073d2cc
I changed the release because conda install was not working
guilhermesena1 Dec 14, 2019
2822221
bumping build number
guilhermesena1 Dec 14, 2019
7fa41fe
fixing shebang location
guilhermesena1 Dec 14, 2019
0d2595a
Merge branch 'master' into master
dpryan79 Dec 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion recipes/falco/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
#!/bin/bash

#to fix problems with htslib
export C_INCLUDE_PATH=$C_INCLUDE_PATH:${PREFIX}/include
export CPLUS_INCLUDE_PATH=$CPLUS_INCLUDE_PATH:${PREFIX}/include
export LIBRARY_PATH=$LIBRARY_PATH:${PREFIX}/lib
export LD_LIBRARY_PATH=$LIBRARY_PATH:${PREFIX}/lib

#!/bin/bash
./configure --prefix=$PREFIX --enable-hts
make
make install
4 changes: 2 additions & 2 deletions recipes/falco/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ package:
version: {{ version }}

build:
number: 0
number: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please start with 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bgruening

I had a pr accepted yesterday that started with 0 so this is the next build. My first commit failed the tests stating I had to increase the number. What should I do for the lint test to pass with build 0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, from the PR it looks like falco is new, which was the cause of the confusion. You might want to pull the master branch from bioconda next time before making changes :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

understood, and sorry again! Still getting the hang of making conda builds. Thank you so much for accepting the PR so quickly!


source:
url: https://github.com/smithlabcode/falco/releases/download/v{{ version }}/falco-{{ version }}.tar.gz
sha256: 0d0bd442012a8a85cea67095c11d0234fa19cdeb43f44a521d55b60e8c1d069a
sha256: e7a3bf1e08356e0e72e24c5b0b65350ee26ed23d28419128422af54fd6abf3b5

requirements:
build:
Expand Down