update sha256sum for falco. Release was changed to be conda compatible #19284
Conversation
|
@BiocondaBot please add label |
|
just a comment for the reviewers: My apologies for sending two PRs in two days. I tested installing the program I'm uploading through conda and realized that, because it depended on some external files, some changes needed to be made so it could run just with the binary. I hope it isn't too much of a problem to just merge the file hash on the metadata for the updated release. Thank you! |
| version: {{ version }} | ||
|
|
||
| build: | ||
| number: 1 |
There was a problem hiding this comment.
Hi @bgruening
I had a pr accepted yesterday that started with 0 so this is the next build. My first commit failed the tests stating I had to increase the number. What should I do for the lint test to pass with build 0?
There was a problem hiding this comment.
Ah, from the PR it looks like falco is new, which was the cause of the confusion. You might want to pull the master branch from bioconda next time before making changes :)
There was a problem hiding this comment.
understood, and sorry again! Still getting the hang of making conda builds. Thank you so much for accepting the PR so quickly!
recipes/falco/build.sh
Outdated
| export LIBRARY_PATH=$LIBRARY_PATH:${PREFIX}/lib | ||
| export LD_LIBRARY_PATH=$LIBRARY_PATH:${PREFIX}/lib | ||
|
|
||
| #!/bin/bash |
There was a problem hiding this comment.
the shebang should be the first line
Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the
please review & mergelabel so other members of the bioconda community can have a look at your PR and either make suggestions or merge it.Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please updatewill cause the BiocondaBot to merge the master branch into a PR@BiocondaBot please add labelwill add theplease review & mergelabel.@BiocondaBot please fetch artifactswill post links to packages and docker containers built by the CI system. You can use this to test packages locally before merging.For members of the Bioconda project, the following command is also available:
@BiocondaBot please mergewill cause packages/containers to be uploaded and a PR merged. Someone must approve a PR first! This has the benefit of not wasting CI build time required by manually merging PRs.If you have questions, please post them in gitter or ping
@bioconda/corein a comment (if you are not able to directly ping@bioconda/corethen the bot will repost your comment and enable pinging).